Fix and conform test cases #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinsun
requested review from
a team,
khushboo-rancher,
lanfon72 and
noahgildersleeve
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
harvester_e2e_tests/integrations/test_1_images.py:303
- Ensure that the new image_checksum parameter is in the correct position to match the updated function signature of create_image_url. If the function was modified recently, double-check that all corresponding documentation and usage reflect this change.
create_image_url(api_client, image_name, image_url, image_checksum, wait_timeout)
harvester_e2e_tests/integrations/test_1_images.py:363
- [nitpick] Verify that adding 1 to the result of the integer division of virtualSize by 1024**3 accurately represents the intended volume size, especially when virtualSize is an exact multiple of 1 GB.
image_size_gb = data["status"]["virtualSize"] // 1024**3 + 1
khushboo-rancher
approved these changes
Apr 7, 2025
Collaborator
|
@albinsun Could you please fix the DCO, sign off the commit? |
Signed-off-by: Albin Sun <[email protected]>
albinsun
force-pushed
the
fix_broken_testcase
branch
from
d5d38a4 to
5ccff82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1977
What this PR does / why we need it:
Fix
test_1_images.py::TestBackendImages::test_delete_image_recreateFix
test_1_images.py::TestBackendImages::test_edit_image_in_usewhich volume size should be greater than the virtual size when Source is VM Image.Special notes for your reviewer:
Additional documentation or context