Skip to content

Conversation

@khushboo-rancher
Copy link
Collaborator

Which issue(s) this PR fixes:

Issue # #2436

What this PR does / why we need it:

  1. Untagged network is used.
  2. Removed the management network from vm.
  3. Added the range of IP in config.

Copilot AI review requested due to automatic review settings January 29, 2026 23:16
@khushboo-rancher khushboo-rancher requested a review from a team January 29, 2026 23:17
@khushboo-rancher
Copy link
Collaborator Author

cc: @asc5543

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the failing test test_verify_vm_dhcp_controller in the managed DHCP add-on tests. The test was failing because VMs were getting IP addresses on the default management network instead of the DHCP-managed network.

Changes:

  • Modified the test to use an untagged network (vlan_id=0) instead of a VLAN-tagged network
  • Disabled the management network on test VMs (spec.mgmt_network = False) to ensure only the DHCP network is used
  • Added IP pool range configuration (192.168.0.81-192.168.0.90) in config.yml

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
harvester_e2e_tests/integrations/test_9_addons.py Changed network creation to use untagged network (vlan_id=0), disabled mgmt_network on VMs, updated DNS to 1.1.1.1, added NTP server, fixed test dependency
config.yml Added IP pool start (192.168.0.81) and end (192.168.0.90) values required for DHCP tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@khushboo-rancher khushboo-rancher changed the title Fix managed-dhcp add tests Fix managed-dhcp addon tests Jan 29, 2026
irishgordo
irishgordo previously approved these changes Jan 30, 2026
Copy link
Contributor

@irishgordo irishgordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ipxe-examples compatibility issues but not a big deal, user can always change settings, they just need to be mindful of things -> this will work however on our regular baremetal loadouts without issue

config.yml Outdated
ip-pool-subnet: '192.168.0.0/24'
ip-pool-start: ''
ip-pool-end: ''
ip-pool-start: '192.168.0.81'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will approve but everyone must be mindful that this conflicts with our default subnet for ipxe examples.

as in 192.168.0.131 for instance is vip, and does fall into this subnet.

when you have a subnet with two possible dhcp handlers it can be bad news

we should think maybe in the future to shift this to be more ipxe-examples compatible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Mike, in ipxe-example, the dhcp_server has the range from 192.168.0.50 ~ 192.168.0.130.
Maybe we can use like 192.168.0.200 ~ 192.168.0.210 as the range here

asc5543
asc5543 previously approved these changes Jan 30, 2026
@khushboo-rancher
Copy link
Collaborator Author

I have adjusted the ip-pool-start and ip-pool-end as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants