Skip to content

Conversation

@liorpr
Copy link

@liorpr liorpr commented Jul 27, 2016

please note:

  1. couldn't figure out the wiring to the css so I simulated the bootstrap and my custom css via link tags in .html, now commented, so should be removed
  2. the logo in the svg has the author credits commented out also, we should find the proper place to insert these, guessed that right under the logo was not the right place:)

This change is Reviewable

@yotammanor
Copy link

  1. Noted. I can help you figure this out, if you want.
  2. Can you maybe look for a credit-free camel svg of similar quality, to avoid the problem altogether? :)

@liorpr
Copy link
Author

liorpr commented Aug 8, 2016

Yeah no problem :)

@yotammanor
Copy link

Hi, @liorpr

I Incorporated the design you made into 404.html, and added the translation strings.
It looks very nice in Hebrew, but in english not just yet.
I created a PR liorpr#1 with my changes, so you can work on it directly. I'll add a print screen here so you can see how it looks in English in case you can't see it locally.

Generally speaking , you should move the css stuff to main-he.css, and rewrite the necessary parts and add those to main-en.css , and this should load the right style for the right language.

Thanks!

@yotammanor
Copy link

image

image

@yotammanor
Copy link

@shavit2310 another possible task is to finish this one, I left some comments on what needs to be done, and it awaits someone brave to take over it :)

@yotammanor
Copy link

yotammanor commented Apr 15, 2017

Things to do on the english page:

  • Incorporate branch yotammanor:liorpr-dev to this pr.
  • move added css to the right location (main-he.css)
  • add necessary css adjustment to main-en.css, such that:
    • Align the quote annotation ("- David Ben Gurion") to the right, similar to the the way it is done in the Hebrew view, but symmetrically.
    • Flip the Camel horizontally.
  • Improve the english translation strings' phrasing:
    • "Does not exist here".
    • "main menu" -> "Homepage"
    • "end" -> "vanquish"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants