perf: improve vehicle location performance and API integration #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored vehicle location data structures to use SiriVehicleLocationWithRelatedPydanticModel. - Updated API calls in gtfsService and siriService to accept optional parameters. - Removed the VehicleLocation model and adjusted related components to align with the new structure. - Enhanced the useVehicleLocations hook to improve data fetching and state management. - Updated map-related components and storybook data to reflect the new data model. - Adjusted tests to accommodate changes in vehicle location handling.
…and correct ride ID reference in LineProfileRide
…mit reduction - Reduced the LIMIT for vehicle location requests from 10,000 to 1,000. - Enhanced the loadData method to accept an AbortSignal for better request management. - Updated fetchWithQueue to handle the AbortSignal, allowing for cancellation of requests. - Modified the LocationObservable constructor to include signal handling.
NoamGaash
approved these changes
Jul 25, 2025
Member
NoamGaash
left a comment
NoamGaash
left a comment
There was a problem hiding this comment.
that's a good change - thank you!
I'm just concerned about the potential performance impact when we use objects instead of primitives as react dependencies, but everything else seems amazing 👍
…bers - Changed the vehicle location request parameters from dayjs objects to timestamps (numbers). - Updated related functions and hooks to handle the new timestamp format. - Ensured compatibility with existing components by adjusting how timestamps are processed and displayed.
…nce workflow_run head_sha
…r handling - Replaced `getRoutesAsync` with `getGTFSRoutes` across various components and hooks for consistency. - Updated route fetching to accept parameters as objects, improving flexibility and readability. - Adjusted related components to handle new parameter structure, ensuring compatibility with existing functionality. - Increased vehicle location request limit from 1,000 to 10,000 for improved data retrieval.
AvivAbachi
commented
Jul 27, 2025
Contributor
NoamGaash
approved these changes
Aug 18, 2025
…VehicleLocations hook
AvivAbachi
changed the title
AvivAbachi
changed the title
Collaborator
Author
|
@NoamGaash I think to improve the map performance on the client side, we need to move the map to WebGL Maps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: update vehicle location handling and API integration
SiriVehicleLocationWithRelatedPydanticModel.gtfsServiceandsiriServiceto accept optional parameters.