Skip to content

feat: added translation for amharic #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
UP11SRE wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: added translation for amharic #1295

UP11SRE wants to merge 13 commits into from

Conversation

@UP11SRE
Copy link
Collaborator

@UP11SRE UP11SRE commented Sep 25, 2025 •
edited
Loading

Description

#1272

1- Added support for Amharic.

screenshots

@UP11SRE UP11SRE requested a review from AvivAbachi as a code owner September 25, 2025 19:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/19994077384/open-bus/1455/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/19994077384/open-bus/1455/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/19994077384/open-bus/7753e845e9a4ecfd95603d628758cb4f6b5eadcd/test-results/index.html'

@AvivAbachi AvivAbachi linked an issue Sep 27, 2025 that may be closed by this pull request
add translate to amharic #1272
Open
@AvivAbachi AvivAbachi changed the title added translation for amharic feat: added translation for amharic Sep 27, 2025
AvivAbachi
AvivAbachi reviewed Sep 27, 2025
View reviewed changes
Copy link
Collaborator

@AvivAbachi AvivAbachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I will send it for checking. It may take some time.
Can you format the src/locale/am.json file with prettier? It is giving you an error.

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Sep 28, 2025

@AvivAbachi @NoamGaash Please review.

@UP11SRE UP11SRE requested a review from AvivAbachi September 28, 2025 10:08
@NoamGaash
Copy link
Member

NoamGaash commented Oct 3, 2025

Code looks great, thank you! 🥳
Let me see if I can find us a language review

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Oct 5, 2025

Hi @NoamGaash, is there any update?

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Oct 11, 2025

Hey @NoamGaash @AvivAbachi any update?

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 2, 2025

@NoamGaash @AvivAbachi, is there any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AvivAbachi AvivAbachi Awaiting requested review from AvivAbachi AvivAbachi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add translate to amharic

5 participants

@UP11SRE @NoamGaash @AvivAbachi @namesoft11