Skip to content

feat: enhance compliant form #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

feat: enhance compliant form #1300

wants to merge 47 commits into from

Conversation

@AvivAbachi
Copy link
Collaborator

@AvivAbachi AvivAbachi commented Sep 27, 2025 •
edited
Loading

list of complient (he)

Server PR #20

  • Client: Build a modular Form
  • Client: Fix Stories
  • Server: Update the schema
  • Server: Implement the TemplateBuild for the complaint base type
  • Package: Update the client API to reflect the new schema
  • Client: Update the client API + Integrated To API

NoamGaash
NoamGaash reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it looks great!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/19070558696/open-bus/1313/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/19070558696/open-bus/1313/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/19070558696/open-bus/cb68ab462763fdb355fe5df02a448cd9b4f53c8d/test-results/index.html'

@AvivAbachi
refactor: move complaint form to config‑driven approach
4af2ca4 
The modal now imports field definitions, mappings, and rendering logic from `ComplaintModalConfig.tsx`.
Inline `renderField` implementation and type declarations have been removed, simplifying maintenance and adding support for new train complaint types.
@AvivAbachi
refactor
021004f
@AvivAbachi
refactor(config): update complaint modal with collapse and select fields
6027c62
@AvivAbachi
refactor(complaint-modal): update API integration and dynamic field h…
187d7e5 
…andling
@AvivAbachi
refacto: improve field handling and validation logic
4105aac
@AvivAbachi
refactor(complaint-modal): restructure complaint modal components and…
ffeef1c 
… consolidate field handling
@AvivAbachi
feat: enhenc date picker and BusOpreatorSelect
a273a66
@AvivAbachi
fix: ride data
77e18de
@AvivAbachi
refactor: consolidate query hooks for complaint form
a610e74
@AvivAbachi
refactor: improve complaint modal route handling
92c7f24
@AvivAbachi
refacto: simplify boarding station query and rename direction fields
1839be4
@AvivAbachi
fix: adjust complaint modal fields and queries
25d48c6
@AvivAbachi
refactor: simplify field handling and dynamic rendering
0959771
@AvivAbachi
refactor: refactor data fetching and form initialization
b884910
@AvivAbachi
refactor: improve form queries and dynamic field rendering
48330bb
@AvivAbachi
perf: optimize data fetching and caching for form queries
1d4fcd4
@AvivAbachi
feat: add route data to complaint modal story
150d689
@AvivAbachi
refactor: refine query keys and form field dependencies
3caefcd
@AvivAbachi
feat: auto-select route based on line data
1e6ca75
@AvivAbachi
feat(complaint-modal): persist user details in complaint form
3dded65
AvivAbachi and others added 14 commits October 27, 2025 14:49
@AvivAbachi
refactor: enhance form handling and type definitions
cda6908
@AvivAbachi
feat: add comprehensive fields and localize
d68be83
@AvivAbachi
refactor: clarify bus operator and query variable names
7caa342
@AvivAbachi
feat: add comprehensive form validation
1e20ac0
@AvivAbachi
feat: enhance form with new fields and mappings
97598f3
@AvivAbachi
feat: enhance complaint type mappings
1f7b725
@AvivAbachi
feat: refine add frequency
46afc23
@AvivAbachi
feat: add station management fields to complaint form
0452526
@AvivAbachi
feat(complaint-form): implement station management and new fields
f0e1d86
@AvivAbachi
feat(complaint-form): refine station add/remove logic and fields
3ac86ff
@AvivAbachi
refactor: refine complaint form labels and messages
94b1eb5
@AvivAbachi
feat(complaint-form): enhance line switch complaint guidance
feae249
@AvivAbachi
refactor: consolidate and simplify validation rule access
bc3b654
@AvivAbachi
Merge branch 'main' into feat/complent-form
d40a70b
NoamGaash
NoamGaash reviewed Oct 29, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoamGaash NoamGaash NoamGaash left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AvivAbachi @NoamGaash