Skip to content

Conversation

@UP11SRE
Copy link
Collaborator

@UP11SRE UP11SRE commented Sep 28, 2025

Description

#1271

1- Added support for Arabic.

screenshots

@UP11SRE UP11SRE requested a review from AvivAbachi as a code owner September 28, 2025 10:08
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2025

@UP11SRE UP11SRE changed the title Translate to arabic feat: added translation for arabic Sep 28, 2025
@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Oct 5, 2025

Hi @NoamGaash, is there any update?

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Oct 11, 2025

Hey @NoamGaash @AvivAbachi any update?

@NoamGaash
Copy link
Member

I've contacted some groups and we're finding an arab speaker to confirm the translation
Thank you for your patience and sorry for the delays

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 2, 2025

@NoamGaash @AvivAbachi, is there any update?

@yarons
Copy link
Collaborator

yarons commented Nov 2, 2025

@UP11SRE Hey, there are lots of issues in this translation, are you an Arabic speaker? Which colloquial?

@NoamGaash
Copy link
Member

@yarons we're looking for help with reviewing and fixing the translations - any help would be appreciated.
Ideally, we'd like the language to be formal (Literary Arabic / Modern Standard Arabic?), but I'm not aware of any Arab volunteers in the project (yet)

@yarons
Copy link
Collaborator

yarons commented Nov 3, 2025

I added some comments about the current translation, I'm starting to doubt if it's worth fixing or needs to be started from scratch, there are many mistakes.

I don't think MSA/Fus7a is a good idea, we have an Israeli colloquial Arabic (ajp according to ISO 639-3) unless the general purpose is a large audience outside Israel which in this case Israeli Arabic is pretty well understood throughout the entire Middle East.

@NoamGaash
Copy link
Member

It sounds great!
@yarons please feel free to replace anything in the ar.json file
I've invited you to have permissions to this repository

@yarons
Copy link
Collaborator

yarons commented Nov 4, 2025

Sadly I'm confident enough to know what's wrong, I'm not confident enough to know what's right :)
I think we can start by changing LTR to RTL, I'll try to ask some friends for help.

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 6, 2025

@yarons @NoamGaash Please let me know the issue i will fix it. however, i am not a native arabic speaker. but i can use Google Translate.

@yarons
Copy link
Collaborator

yarons commented Nov 6, 2025

@UP11SRE as I said in my comments, there are lots of mistakes, starting with the fact that Arabic is RTL and not LTR.

Google Translate is a poor decision for this translation, if you have enough tokens just go to Claude, feed it with the Hebrew translation and tell it to translate this document to Israeli Arabic instead of this nonsense.

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 7, 2025

@UP11SRE as I said in my comments, there are lots of mistakes, starting with the fact that Arabic is RTL and not LTR.

Google Translate is a poor decision for this translation, if you have enough tokens just go to Claude, feed it with the Hebrew translation and tell it to translate this document to Israeli Arabic instead of this nonsense.

cool will do that by tomorrow. @yarons

@NoamGaash NoamGaash requested review from yarons and removed request for AvivAbachi November 8, 2025 17:49
@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 9, 2025

@yarons, could you please review once?

@yarons
Copy link
Collaborator

yarons commented Nov 9, 2025

@UP11SRE it looks way better, look at my new comments, I'll try to bring native Arab speakers to this conversation.

@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 9, 2025

@yarons I am not able to see your comments, could you please share it again?

@NoamGaash
Copy link
Member

@yarons if you have pending comments, it will become visible after submitting the review :)
image

Copy link
Collaborator

@yarons yarons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UP11SRE @NoamGaash I thought it was visible all along, sorry.

@NoamGaash NoamGaash requested a review from yarons November 19, 2025 10:17
@UP11SRE
Copy link
Collaborator Author

UP11SRE commented Nov 20, 2025

@yarons Please review.

@yarons
Copy link
Collaborator

yarons commented Nov 26, 2025

I can't get my Arab speaking friends to look at it, I'll approve it as is and we'll work on fixes in the future, good luck.

@olabie2
Copy link
Collaborator

olabie2 commented Dec 1, 2025

@NoamGaash @yarons I am Arab Israeli if you guys want help on this translation.

@NoamGaash
Copy link
Member

@olabie2 that would be amazing, thanks!
feel free to contribute to this PR, permissions granted

@NoamGaash
Copy link
Member

@all-contributors please add @olabie2 for contributing translation!
Thank you so much 👑

@allcontributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @olabie2! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants