fix: add loading indicator overlay to velocity heatmap page - #1523
Open
eran132 wants to merge 2 commits into
Open
fix: add loading indicator overlay to velocity heatmap page#1523eran132 wants to merge 2 commits into
eran132 wants to merge 2 commits into
Conversation
The velocity heatmap page loads data slowly but previously showed only a pink div with "loading!" text, making users think the page was broken. Replaced with a proper semi-transparent overlay with MUI CircularProgress spinner and descriptive text, consistent with loading patterns used in the gaps and timeline pages. Also added an Alert component for error states. Closes #1483 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the UX of the velocity heatmap page by replacing the previous “loading!” text with a proper loading overlay and adding a user-visible error alert, with loading/error state lifted from VelocityHeatmapRectangles to the page component.
Changes:
- Add an MUI
CircularProgressoverlay while heatmap data is loading. - Show an MUI
Alerton error states. - Propagate
loading/errorfromVelocityHeatmapRectanglesto the parent via new callbacks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/velocityHeatmap/index.tsx | Adds loading overlay + error alert UI and wires callbacks from the rectangles layer. |
| src/pages/velocityHeatmap/components/VelocityHeatmapRectangles.tsx | Introduces onLoadingChange / onErrorChange callbacks and removes the old inline loading/error div. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@all-contributors please add @eran132 as a code contributor to this repository |
Contributor
|
@eran132 already contributed before to code |
…loading-indicator # Conflicts: # src/pages/velocityHeatmap/components/VelocityHeatmapRectangles.tsx
AvivAbachi
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitted from upstream branch (previously #1504). Approved by @AvivAbachi.
Summary
Closes #1483
Test plan
🤖 Generated with Claude Code