-
-
Notifications
You must be signed in to change notification settings - Fork 128
feat: add sticky inputs section to gaps and timeline pages #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eran132
wants to merge
8
commits into
main
Choose a base branch
from
feat/sticky-inputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1d75520
feat: add sticky inputs section to gaps and timeline pages
eran132 bc990ab
Merge remote-tracking branch 'origin/main' into feat/sticky-inputs
eran132 7261786
fix: give StickyInputs an opaque themed background
eran132 a52dd04
Merge branch 'main' into feat/sticky-inputs
NoamGaash 09110d3
Merge branch 'main' into feat/sticky-inputs
NoamGaash 11b0992
Merge remote-tracking branch 'origin/main' into feat/sticky-inputs
eran132 0ee0d40
fix: StickyInputs transparent at rest, opaque only when scrolled
eran132 27fba87
style: prettier formatting on StickyInputs
eran132 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { styled } from '@mui/material/styles' | ||
| import { type ReactNode, useEffect, useRef, useState } from 'react' | ||
|
|
||
| // Pinned filter section. Transparent at rest (matches the pre-PR baseline — | ||
| // no visible container box on the gaps page); becomes opaque using the MUI | ||
| // theme's default page background only once the scrollable ancestor has | ||
| // actually scrolled, which is exactly when content would otherwise bleed | ||
| // through. This avoids the visual regression Noam flagged while preserving | ||
| // the bleed-through fix earlier in #1528. | ||
| const Container = styled('div')(({ theme }) => ({ | ||
| position: 'sticky', | ||
| top: 0, | ||
| zIndex: 100, | ||
| paddingBottom: 8, | ||
| '&[data-stuck="true"]': { | ||
| backgroundColor: theme.palette.background.default, | ||
| }, | ||
| })) | ||
|
|
||
| function findScrollableAncestor(el: HTMLElement): HTMLElement | null { | ||
| let parent: HTMLElement | null = el.parentElement | ||
| while (parent) { | ||
| const { overflowY } = getComputedStyle(parent) | ||
| if (overflowY === 'auto' || overflowY === 'scroll' || overflowY === 'overlay') { | ||
| return parent | ||
| } | ||
| parent = parent.parentElement | ||
| } | ||
| return null | ||
| } | ||
|
|
||
| export const StickyInputs = ({ children }: { children: ReactNode }) => { | ||
| const ref = useRef<HTMLDivElement>(null) | ||
| const [stuck, setStuck] = useState(false) | ||
|
|
||
| useEffect(() => { | ||
| const el = ref.current | ||
| if (!el) return | ||
| const scrollAncestor = findScrollableAncestor(el) | ||
| const target: HTMLElement | Window = scrollAncestor ?? window | ||
| const getScroll = () => (scrollAncestor ? scrollAncestor.scrollTop : window.scrollY) | ||
| const check = () => setStuck(getScroll() > 0) | ||
| check() | ||
| target.addEventListener('scroll', check, { passive: true }) | ||
| return () => target.removeEventListener('scroll', check) | ||
| }, []) | ||
|
|
||
| return ( | ||
| <Container ref={ref} data-stuck={stuck ? 'true' : 'false'}> | ||
| {children} | ||
| </Container> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import style for
StickyInputsis inconsistent across pages: this file uses an absolutesrc/...import whilesrc/pages/gaps/index.tsxuses a relative../components/StickyInputs. Standardizing on one convention improves consistency and avoids path-alias-only builds causing import churn (and can prevent accidental duplicate module instances in some setups).