refactor: migrate storybook mocking to sb.mock() - #1832
Open
jonsuguiyama wants to merge 1 commit into
Open
Conversation
Storybook 10's sb.mock() replaces the per-story MSW HTTP handlers (hardcoded URLs, manual JSON responses) with module-level mocks of the actual data-fetching hooks/functions, registered once in .storybook/preview.tsx. Migrated: OperatorGaps, BusToolTip, ComplaintModal, MapWithLocationsAndPath, AllLinesChart, DayTimeChart, WorstLinesChart, OperatorRoutes, VelocityHeatmapRectangles. Dropped an MSW handler for /siri_rides/list in BusToolTip and ComplaintModal stories. Verified across the whole repo (every caller of siriRidesListGet, plus the full import tree of both components and their children) that neither component ever reaches that endpoint, so it was mocking a request that never happens. Requires allowImportingTsExtensions in tsconfig.json, needed for sb.mock()'s static import-path analysis.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mocking the actual hooks/functions instead of intercepting HTTP
by URL
verified repo-wide (every caller of siriRidesListGet, full import
tree of both components and their children) that it never runs
Test plan
Closes #1455