fix: rides_execution not retune time whit time zone - #52
Merged
OriHoch merged 2 commits intoOct 28, 2025
Merged
Conversation
OriHoch
requested changes
Oct 28, 2025
OriHoch
left a comment
Contributor
There was a problem hiding this comment.
all the times are sent in UTC, so there is no need to add a timezone it will always be +00:00
you should handle timezone in the client-side
also, I think API should have consistent behavior currently it always returns times in UTC for all responses, so if this change is really needed then it should be applied globally to all responses, but that would be a big change affecting many places and users of the API, so I would recommend not to do that
Contributor
Author
[
{
"planned_start_time": "2024-11-03T03:45:00",
"actual_start_time": "2024-11-03T03:45:00",
"gtfs_ride_id": 91413633
}
]
[
{
"planned_start_time": "2024-11-03T03:45:00+00:00",
"actual_start_time": "2024-11-03T03:45:00+00:00",
"gtfs_ride_id": 91413633
}
]This is the only place it is not returning with +00:00 |
Contributor
|
you are right my mistake, I see most other places also return with timezone |
AvivAbachi
deleted the
fix/rides_execution-not-retune-time-whit-timezone
branch
October 28, 2025 07:31
This was referenced Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a case of setting the wrong timezone in the client, resulting in incorrect data displayed on the gap page.