fix: start_time_to was bound to end_time instead of start_time - #59
Open
arielvino wants to merge 2 commits into
Open
fix: start_time_to was bound to end_time instead of start_time#59arielvino wants to merge 2 commits into
arielvino wants to merge 2 commits into
Conversation
arielvino
marked this pull request as ready for review
July 27, 2026 09:24
Remove test for filtering GTFS rides based on start time.
Contributor
Author
|
@OriHoch Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in the router was feeding the param
start_time_toongtfs_ridesintomodel.GtfsRide.end_time.Causing every ride that start within the window but ends after it to be excluded.
Example
1) how many rides START at exactly 12:00 on 2026-07-20?
2) ...yet here they are, listed by start_time