changes in GTFS-Reader (of Siri Retriever) - #305
Open
evyatark wants to merge 33 commits into
Open
Conversation
…n-bus into siri_retriever_debug
…ion (preparing to docker), in classes [GtfsDataManip, SchedulingDataCre, GtfsCollectorSer] I remained with my version because it contains some necessary fixes. Logic changes in GtfsFtp and GtfsZipFile should be investigated
# Conflicts: # siri/gtfs_reader/.gitignore # siri/gtfs_reader/.settings/org.eclipse.core.resources.prefs # siri/gtfs_reader/.settings/org.eclipse.jdt.core.prefs # siri/gtfs_reader/.settings/org.eclipse.m2e.core.prefs # siri/gtfs_reader/pom.xml # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/analysis/GtfsDataManipulations.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/analysis/SchedulingDataCreator.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/crud/DownloadFailedException.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/crud/FtpClientService.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/crud/GtfsRetriever.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/crud/GtfsZipFile.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/main/GtfsCollectorConfiguration.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/main/GtfsCollectorService.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/main/GtfsCollectorStartup.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/service/BackupCleanupService.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/service/SiriCollectorClient.java # siri/gtfs_reader/src/main/java/il/org/hasadna/siri_client/gtfs/service/SiriCollectorClientImpl.java # siri/gtfs_reader/src/main/resources/applicationContext.xml # siri/gtfs_reader/src/main/resources/sdf.tmp # siri/gtfs_reader/src/test/java/il/org/hasadna/siri_client/gtfs/crud/GtfsCrudTest.java # siri/gtfs_reader/src/test/java/il/org/hasadna/siri_client/gtfs/crud/GtfsZipFileTest.java # siri/gtfs_reader/src/test/java/il/org/hasadna/siri_client/gtfs/service/TestBackupCleanupService.java
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 3 3
Lines 116 116
=======================================
Hits 109 109
Misses 7 7Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 3 3
Lines 116 116
=======================================
Hits 109 109
Misses 7 7 Continue to review full report at Codecov.
|
OrBin
removed their request for review
November 18, 2021 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
many changes made by Eldad and then by me.
This branch is very similar to the version that was running until now in the SIRI RT machine (Ocean Digital)
This version will now run in SIRI RT machine.
These changes are needed so we can gradually move to a GTFS-Reader running on docker.