Refactor & Improve OTP Input Focus #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokhosh
reviewed
Jan 4, 2025
mokhosh
left a comment
mokhosh
left a comment
There was a problem hiding this comment.
Also, can't we just rely on autofocus html attribute and remove JS logic for handling auto focus?
| } | ||
|
|
||
| public function rtl(bool|\Closure $condition = false): static | ||
| public function rtl(bool|\Closure $condition = true): static |
| :hint-actions="$getHintActions()" | ||
| :hint-icon="$getHintIcon()" | ||
| :required="$isRequired()" | ||
| :state-path="$getStatePath()" |
There was a problem hiding this comment.
This can also be replaced with a variable if you're already extracting.
| const input = e.target; | ||
| if(input.value.length > 1){ | ||
| input.value = input.value.substring(0, 1); | ||
| state: $wire.$entangle('{{ $statePath }}'), |
There was a problem hiding this comment.
I would separate style fixes and functional changes into separate PRs for easier reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved the Issue #7 related to incorrect focus handling in OTP input fields, including autofocus, input navigation, paste behavior, and backspace handling. The changes involve improving focus logic using
this.$nextTick()and refactoring thehandleInput()andhandlePaste()methods for better reliability. General changes code refactoring to enhance readability and maintainability and fixed styling were also included.Also, change the rtl method to set default the condition to
true.