Skip to content

⚡ Bolt: [performance improvement] Pre-compile regex patterns in ExecutionSafetyManager #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haseeb-heaven wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Pre-compile regex patterns in ExecutionSafetyManager #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Pre-compiling Regex in Class Scope
**Learning:** In Python 3, list comprehensions inside a class body do not have access to the class's scope, leading to `NameError`. Bypassing Python's internal regex cache by directly executing pre-compiled `re.Pattern` objects (`p.search(text)`) in tight loops yields measurable performance improvements.
**Action:** Pre-compile regular expressions into a tuple of `re.Pattern` objects using a generator expression (e.g., `tuple(re.compile(p) for p in _PATTERNS)`) at the class level instead of building massive `|` joined strings or relying on the internal cache.
17 changes: 11 additions & 6 deletions libs/safety_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ class ExecutionSafetyManager:
r'\.to_excel\s*\([^)]*[\'"/]',
r'\.to_parquet\s*\([^)]*[\'"/]',
]
_WRITE_PATTERNS_COMPILED = tuple(re.compile(p, re.IGNORECASE) for p in _WRITE_PATTERNS)

# BUG FIX (test_blocks_write_function_with_absolute_path):
# When code opens a file handle (any mode, including 'r') and then calls
Expand All @@ -111,6 +112,7 @@ class ExecutionSafetyManager:
_WRITE_ON_HANDLE_PATTERNS = [
r"\.write\s*\(",
]
_WRITE_ON_HANDLE_PATTERNS_COMPILED = tuple(re.compile(p, re.IGNORECASE) for p in _WRITE_ON_HANDLE_PATTERNS)

# Sensitive POSIX system path prefixes that are ALWAYS blocked (even for reads).
_SENSITIVE_POSIX_PREFIXES = [
Expand All @@ -121,6 +123,7 @@ class ExecutionSafetyManager:
r"/dev/\w+",
r"/boot/\w+",
]
_SENSITIVE_POSIX_PREFIXES_COMPILED = tuple(re.compile(p, re.IGNORECASE) for p in _SENSITIVE_POSIX_PREFIXES)

# Known-dangerous call targets for .remove() / .unlink() / .rmtree().
_DANGEROUS_ATTR_OWNERS = frozenset({"os", "shutil", "pathlib", "path"})
Expand Down Expand Up @@ -166,6 +169,7 @@ class ExecutionSafetyManager:
r"\bformat\s+[a-z]:",
r"\bdiskpart\b",
]
_DESTRUCTIVE_PATTERNS_COMPILED = tuple(re.compile(p) for p in _DESTRUCTIVE_PATTERNS)

# =========================
# BUG FIX #2: Shell patterns now use re.search() with \b word boundaries
Expand All @@ -179,6 +183,7 @@ class ExecutionSafetyManager:
r"\bcmd\.exe\b",
r"\bbash\b",
]
_SHELL_PATTERNS_COMPILED = tuple(re.compile(p) for p in _SHELL_PATTERNS)

def __init__(self, unsafe_mode: bool = False):
self.unsafe_mode = unsafe_mode
Expand Down Expand Up @@ -228,7 +233,7 @@ def _has_write_operation(self, code: str) -> bool:
"""Return True if *code* contains any write operation that must be
blocked in SAFE mode.
"""
return any(re.search(p, code, re.IGNORECASE) for p in self._WRITE_PATTERNS)
return any(p.search(code) for p in self._WRITE_PATTERNS_COMPILED)

# =========================
# WRITE-ON-HANDLE DETECTION
Expand All @@ -240,7 +245,7 @@ def _has_write_on_handle(self, code: str) -> bool:
"""Return True if *code* calls .write() on any object (handle check).
This is intentionally only evaluated when an absolute path is present.
"""
return any(re.search(p, code, re.IGNORECASE) for p in self._WRITE_ON_HANDLE_PATTERNS)
return any(p.search(code) for p in self._WRITE_ON_HANDLE_PATTERNS_COMPILED)

# =========================
# HOST ABSOLUTE PATH CHECK
Expand Down Expand Up @@ -285,7 +290,7 @@ def _is_host_absolute_path(self, code: str) -> bool:

def _is_sensitive_posix_path(self, code: str) -> bool:
"""Return True if *code* references a sensitive POSIX system path."""
return any(re.search(p, code, re.IGNORECASE) for p in self._SENSITIVE_POSIX_PREFIXES)
return any(p.search(code) for p in self._SENSITIVE_POSIX_PREFIXES_COMPILED)

# =========================
# MAIN CHECK
Expand Down Expand Up @@ -326,15 +331,15 @@ def assess_execution(self, code: str, mode: str) -> Decision:
# (shutdown, reboot, mkfs, dd, format, diskpart) in addition to
# filesystem deletes.
# =========================
if any(re.search(p, code_lower) for p in self._DESTRUCTIVE_PATTERNS):
if any(p.search(code_lower) for p in self._DESTRUCTIVE_PATTERNS_COMPILED):
return Decision(False, ["Destructive operation blocked."])

# =========================
# SHELL BLOCK
# BUG FIX #2: Uses _SHELL_PATTERNS with \b word-boundary regex instead
# of plain substring `in` check to avoid false positives.
# =========================
if any(re.search(p, code_lower) for p in self._SHELL_PATTERNS):
if any(p.search(code_lower) for p in self._SHELL_PATTERNS_COMPILED):
return Decision(False, ["Shell execution is blocked."])

# =========================
Expand Down Expand Up @@ -370,7 +375,7 @@ def is_dangerous_operation(self, code: str) -> bool:
if not code or not code.strip():
return False
code_lower = code.lower()
return any(re.search(p, code_lower) for p in self._DESTRUCTIVE_PATTERNS)
return any(p.search(code_lower) for p in self._DESTRUCTIVE_PATTERNS_COMPILED)

# =========================
# ARTIFACT EXPORT
Expand Down
Loading