Skip to content

⚡ Bolt: [performance improvement] Pre-compile regex patterns in ExecutionSafetyManager #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haseeb-heaven wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Pre-compile regex patterns in ExecutionSafetyManager #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Pre-compile regular expressions in safety-critical loops
**Learning:** Using `re.search` with string patterns in tight loops (like those in `ExecutionSafetyManager`) introduces unnecessary overhead. Bypassing the cache by executing pre-compiled `re.Pattern` objects (`p.search(text)`) is measurably faster.
**Action:** Always pre-compile regular expressions as class-level attributes using generator expressions converted to tuples (e.g., `tuple(re.compile(p) for p in _PATTERNS)`) when optimizing repeated regex matching with `any()` inside class methods.
73 changes: 46 additions & 27 deletions libs/safety_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,40 @@ class ExecutionSafetyManager:
r"\bbash\b",
]

_POSIX_SYSTEM_PREFIXES = [
r"/etc/\w+",
r"/tmp/\w+",
r"/var/\w+",
r"/usr/\w+",
r"/root/\w+",
r"/home/\w+/",
r"/proc/\w+",
r"/sys/\w+",
r"/dev/\w+",
r"/boot/\w+",
r"/opt/\w+",
r"/mnt/\w+",
r"/media/\w+",
]

# ⚡ Bolt Optimization: Pre-compile regular expressions.
# Using re.search with string patterns in tight loops (like assess_execution)
# incurs parsing and cache-lookup overhead. Bypassing Python's internal cache
# by executing pre-compiled re.Pattern objects directly (p.search(code))
# provides a measurable speedup during safety checks.
_COMPILED_WRITE_PATTERNS = tuple(re.compile(p, re.IGNORECASE) for p in _WRITE_PATTERNS)
_COMPILED_WRITE_ON_HANDLE_PATTERNS = tuple(re.compile(p, re.IGNORECASE) for p in _WRITE_ON_HANDLE_PATTERNS)
_COMPILED_SENSITIVE_POSIX_PREFIXES = tuple(re.compile(p, re.IGNORECASE) for p in _SENSITIVE_POSIX_PREFIXES)
_COMPILED_DESTRUCTIVE_PATTERNS = tuple(re.compile(p) for p in _DESTRUCTIVE_PATTERNS)
_COMPILED_SHELL_PATTERNS = tuple(re.compile(p) for p in _SHELL_PATTERNS)
_COMPILED_POSIX_SYSTEM_PREFIXES = tuple(re.compile(p, re.IGNORECASE) for p in _POSIX_SYSTEM_PREFIXES)

_COMPILED_WINDOWS_DRIVE_PATTERN = re.compile(r"[a-z]:[\\/]")
_COMPILED_POSIX_ABS_PATH_PATTERN = re.compile(r"""["']/[^"'\s]""")
_COMPILED_OPEN_PATH_PATTERN = re.compile(r"open\s*\(\s*([\"'][^\"']+[\"'])", re.IGNORECASE)
_COMPILED_WINDOWS_DRIVE_EXACT_PATTERN = re.compile(r"[a-zA-Z]:[\\/]")
_COMPILED_RD_PATTERN = re.compile(r"\brd\s+/s\s+/q\b")

def __init__(self, unsafe_mode: bool = False):
self.unsafe_mode = unsafe_mode

Expand Down Expand Up @@ -228,7 +262,7 @@ def _has_write_operation(self, code: str) -> bool:
"""Return True if *code* contains any write operation that must be
blocked in SAFE mode.
"""
return any(re.search(p, code, re.IGNORECASE) for p in self._WRITE_PATTERNS)
return any(p.search(code) for p in self._COMPILED_WRITE_PATTERNS)

# =========================
# WRITE-ON-HANDLE DETECTION
Expand All @@ -240,52 +274,37 @@ def _has_write_on_handle(self, code: str) -> bool:
"""Return True if *code* calls .write() on any object (handle check).
This is intentionally only evaluated when an absolute path is present.
"""
return any(re.search(p, code, re.IGNORECASE) for p in self._WRITE_ON_HANDLE_PATTERNS)
return any(p.search(code) for p in self._COMPILED_WRITE_ON_HANDLE_PATTERNS)

# =========================
# HOST ABSOLUTE PATH CHECK
# =========================
def _is_host_absolute_path(self, code: str) -> bool:
"""Return True if *code* references a host absolute path."""
# Windows drive-letter path
if re.search(r"[a-z]:[\\/]", code.lower()):
if self._COMPILED_WINDOWS_DRIVE_PATTERN.search(code.lower()):
return True

# Quoted POSIX absolute path: '/...' or "/..."
if re.search(r"""["']/[^"'\s]""", code):
if self._COMPILED_POSIX_ABS_PATH_PATTERN.search(code):
return True

# Unquoted well-known POSIX system directory prefixes
_posix_system_prefixes = [
r"/etc/\w+",
r"/tmp/\w+",
r"/var/\w+",
r"/usr/\w+",
r"/root/\w+",
r"/home/\w+/",
r"/proc/\w+",
r"/sys/\w+",
r"/dev/\w+",
r"/boot/\w+",
r"/opt/\w+",
r"/mnt/\w+",
r"/media/\w+",
]
if any(re.search(p, code, re.IGNORECASE) for p in _posix_system_prefixes):
if any(p.search(code) for p in self._COMPILED_POSIX_SYSTEM_PREFIXES):
return True

# open() call whose first positional argument is an absolute path string
open_args = re.findall(r"open\s*\(\s*([\"'][^\"']+[\"'])", code, re.IGNORECASE)
open_args = self._COMPILED_OPEN_PATH_PATTERN.findall(code)
for arg in open_args:
path = arg.strip("'\"")
if path.startswith("/") or re.match(r"[a-zA-Z]:[\\/]", path):
if path.startswith("/") or self._COMPILED_WINDOWS_DRIVE_EXACT_PATTERN.match(path):
return True

return False

def _is_sensitive_posix_path(self, code: str) -> bool:
"""Return True if *code* references a sensitive POSIX system path."""
return any(re.search(p, code, re.IGNORECASE) for p in self._SENSITIVE_POSIX_PREFIXES)
return any(p.search(code) for p in self._COMPILED_SENSITIVE_POSIX_PREFIXES)

# =========================
# MAIN CHECK
Expand All @@ -297,7 +316,7 @@ def assess_execution(self, code: str, mode: str) -> Decision:
code_lower = code.lower()

# HARD BLOCK WINDOWS RECURSIVE DELETE (CRITICAL FIX)
if re.search(r"\brd\s+/s\s+/q\b", code_lower):
if self._COMPILED_RD_PATTERN.search(code_lower):
return Decision(False, ["Recursive deletion is blocked."])

# UNSAFE MODE - still detect dangerous operations but allow with warnings
Expand Down Expand Up @@ -326,15 +345,15 @@ def assess_execution(self, code: str, mode: str) -> Decision:
# (shutdown, reboot, mkfs, dd, format, diskpart) in addition to
# filesystem deletes.
# =========================
if any(re.search(p, code_lower) for p in self._DESTRUCTIVE_PATTERNS):
if any(p.search(code_lower) for p in self._COMPILED_DESTRUCTIVE_PATTERNS):
return Decision(False, ["Destructive operation blocked."])

# =========================
# SHELL BLOCK
# BUG FIX #2: Uses _SHELL_PATTERNS with \b word-boundary regex instead
# of plain substring `in` check to avoid false positives.
# =========================
if any(re.search(p, code_lower) for p in self._SHELL_PATTERNS):
if any(p.search(code_lower) for p in self._COMPILED_SHELL_PATTERNS):
return Decision(False, ["Shell execution is blocked."])

# =========================
Expand Down Expand Up @@ -370,7 +389,7 @@ def is_dangerous_operation(self, code: str) -> bool:
if not code or not code.strip():
return False
code_lower = code.lower()
return any(re.search(p, code_lower) for p in self._DESTRUCTIVE_PATTERNS)
return any(p.search(code_lower) for p in self._COMPILED_DESTRUCTIVE_PATTERNS)

# =========================
# ARTIFACT EXPORT
Expand Down
Loading