Skip to content

[Mirror] [ENH](wal3): add optional upload fault injector (upstream #6849)#2

Closed
hashbender wants to merge 4 commits intomainfrom
mirror/upstream-pr-6849
Closed

[Mirror] [ENH](wal3): add optional upload fault injector (upstream #6849)#2
hashbender wants to merge 4 commits intomainfrom
mirror/upstream-pr-6849

Conversation

@hashbender
Copy link
Copy Markdown
Owner

Mirrored from chroma-core#6849 for Tenki Code Review demo

rescrv added 4 commits April 1, 2026 13:02
Add the fault injection proto service and the new chroma-faults crate
for in-process fault state management.

Implement inject, list, and clear RPCs over a shared FaultRegistry,
and wire log-service to build and expose the new tonic service while
registering the shared Arc in the config registry.

Co-authored-by: AI
Add a generic fragment-manager shim in wal3 that can wrap
fragment uploaders with an optional fault injector.

Wire chroma-log-service's FaultRegistry through the S3,
repl, and copy/open paths so fragment uploads can be
delayed or failed via the wal3.fragment_upload label.

Keep the injector optional for callers that do not want
fault injection, and add focused wal3 and log-service
coverage for the new path.

Co-authored-by: AI
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@hashbender
Copy link
Copy Markdown
Owner Author

@tenki-reviewer

@tenki-reviewer
Copy link
Copy Markdown

tenki-reviewer bot commented Apr 9, 2026

Tenki Code Review - Complete

Files Reviewed: 12
Findings: 0


I reviewed the PR changes across the new fault-injection plumbing and WAL3 integration, and did not identify actionable code-quality or security issues reachable with current callers. The changes appear internally consistent and feature-gated where behavior changes occur.

Files Reviewed (12 files)
Cargo.toml
idl/chromadb/proto/fault_injection.proto
rust/config/src/registry.rs
rust/faults/Cargo.toml
rust/faults/src/lib.rs
rust/log-service/Cargo.toml
rust/log-service/src/lib.rs
rust/types/build.rs
rust/wal3/src/interfaces/mod.rs
rust/wal3/src/interfaces/repl/mod.rs
rust/wal3/src/interfaces/s3/mod.rs
rust/wal3/src/lib.rs

@hashbender hashbender closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants