[Mirror] [ENH](wal3): add optional upload fault injector (upstream #6849)#2
Closed
hashbender wants to merge 4 commits intomainfrom
Closed
[Mirror] [ENH](wal3): add optional upload fault injector (upstream #6849)#2hashbender wants to merge 4 commits intomainfrom
hashbender wants to merge 4 commits intomainfrom
Conversation
Add the fault injection proto service and the new chroma-faults crate for in-process fault state management. Implement inject, list, and clear RPCs over a shared FaultRegistry, and wire log-service to build and expose the new tonic service while registering the shared Arc in the config registry. Co-authored-by: AI
Add a generic fragment-manager shim in wal3 that can wrap fragment uploaders with an optional fault injector. Wire chroma-log-service's FaultRegistry through the S3, repl, and copy/open paths so fragment uploads can be delayed or failed via the wal3.fragment_upload label. Keep the injector optional for callers that do not want fault injection, and add focused wal3 and log-service coverage for the new path. Co-authored-by: AI
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Owner
Author
|
Tenki Code Review - Complete Files Reviewed: 12 I reviewed the PR changes across the new fault-injection plumbing and WAL3 integration, and did not identify actionable code-quality or security issues reachable with current callers. The changes appear internally consistent and feature-gated where behavior changes occur. Files Reviewed (12 files) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from chroma-core#6849 for Tenki Code Review demo