Skip to content

feat: add security breakdown endpoint support#2

Merged
kantorcodes merged 1 commit intomainfrom
feat/skill-security-breakdown-support
Mar 4, 2026
Merged

feat: add security breakdown endpoint support#2
kantorcodes merged 1 commit intomainfrom
feat/skill-security-breakdown-support

Conversation

@kantorcodes
Copy link
Copy Markdown
Member

Summary

  • add GetSkillSecurityBreakdown method to registrybroker client
  • add SkillSecurityBreakdownOptions with JobID
  • support feature route /skills/{jobId}/security-breakdown
  • update coverage test for the feature method

Why

This adds Go client support for the new Security Breakdown feature.

Verification

  • go test ./pkg/registrybroker/...

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Go client support for a new Security Breakdown feature. It provides the necessary client method and data structures to interact with the /skills/{jobId}/security-breakdown API endpoint, allowing applications to retrieve security analysis results for specific skill releases.

Highlights

  • New Endpoint Support: Added the GetSkillSecurityBreakdown method to the registrybroker client, enabling support for fetching security breakdown information for skills.
  • New Options Struct: Introduced SkillSecurityBreakdownOptions which includes a JobID field, used for specifying the target skill release for the security breakdown.
  • API Route Integration: Integrated support for the /skills/{jobId}/security-breakdown feature route within the client.
  • Test Coverage: Updated the coverage test to include a call to the newly added GetSkillSecurityBreakdown method, ensuring test coverage for the new feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pkg/registrybroker/coverage_test.go
    • Added a call to client.GetSkillSecurityBreakdown to ensure test coverage for the new endpoint.
  • pkg/registrybroker/skills.go
    • Implemented the GetSkillSecurityBreakdown method, which constructs the API path using the provided JobID and makes a GET request.
    • Included input validation to ensure the JobID is not empty.
  • pkg/registrybroker/types.go
    • Defined the SkillSecurityBreakdownOptions struct, containing a JobID field.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds client support for a new security breakdown endpoint. The changes include a new method on the client, a corresponding options struct, and an update to the coverage test. The implementation is solid, but I've noted a small opportunity for code cleanup by removing a redundant function call.

@kantorcodes kantorcodes force-pushed the feat/skill-security-breakdown-support branch from 84fb7f9 to 4327684 Compare March 3, 2026 21:10
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kantorcodes kantorcodes force-pushed the feat/skill-security-breakdown-support branch from 4327684 to 29f10bf Compare March 3, 2026 21:12
@kantorcodes kantorcodes merged commit c662b71 into main Mar 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant