-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to HIP-869 #1089
Open
Mark-Swirlds
wants to merge
5
commits into
hashgraph:main
Choose a base branch
from
Mark-Swirlds:update-dab-hip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updates to HIP-869 #1089
+82
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrote user stories adding 2 new stories for node operator NodeCreate & NodeDelete - Added section describing admin key operations - Added details on initial enablement of feature and admin key bootstrapping - Added table listing required signatures by DAB endpoint - Changed NodeDelete permissions from council sig to either council OR admin key sig - Added details on DAB request order of operations for applying DAB changes to config.txt and 101/102 - removed TransactionReceipt protobuf to remove mention of updateNode & deleteNode - removed reference for internal external IP entry ordering Signed-off-by: Mark Blackman <[email protected]>
- Rewrote user stories adding 2 new stories for node operator NodeCreate & NodeDelete - Added section describing admin key operations - Added details on initial enablement of feature and admin key bootstrapping - Added table listing required signatures by DAB endpoint - Changed NodeDelete permissions from council sig to either council OR admin key sig - Added details on DAB request order of operations for applying DAB changes to config.txt and 101/102 - removed TransactionReceipt protobuf to remove mention of updateNode & deleteNode - removed reference for internal external IP entry ordering
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mgarbs
approved these changes
Jan 7, 2025
mgarbs
previously approved these changes
Jan 23, 2025
Signed-off-by: Michael Garber <[email protected]>
mgarbs
approved these changes
Jan 23, 2025
mgarbs
previously approved these changes
Jan 23, 2025
Signed-off-by: Mark Blackman <[email protected]>
changed update date to proper format Signed-off-by: Mark Blackman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist