feat: Add dependency injections to all remaining command classes #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…ning-command-classes # Conflicts: # src/core/middlewares.ts # src/index.ts # test/e2e/integration/commands/init.test.ts # test/helpers/command-invoker.ts # test/unit/commands/network.test.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Unit Test Results - Windows 1 files ±0 68 suites - 2 4s ⏱️ -1s Results for commit 1deeac9. ± Comparison against base commit 61f369c. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
Signed-off-by: Ivo Yankov <[email protected]>
…ning-command-classes # Conflicts: # src/core/dependency-injection/container-init.ts # src/core/dependency-injection/inject-tokens.ts # src/core/middlewares.ts # src/index.ts # test/helpers/command-invoker.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…ning-command-classes # Conflicts: # src/commands/base.ts # src/commands/explorer.ts # src/commands/init.ts # src/commands/mirror-node.ts # src/commands/network.ts # src/commands/node/index.ts # src/commands/relay.ts # src/core/command-handler.ts # src/core/dependency-injection/container-init.ts # src/index.ts # test/e2e/commands/account.test.ts # test/e2e/commands/dual-cluster-full.test.ts # test/e2e/integration/commands/init.test.ts # test/helpers/command-invoker.ts # test/test-util.ts # test/unit/commands/cluster.test.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…o-all-remaining-command-classes # Conflicts: # src/commands/base.ts # src/commands/relay.ts # src/core/dependency-injection/container-init.ts # src/index.ts # test/e2e/integration/commands/init.test.ts # test/unit/commands/cluster.test.ts # test/unit/commands/network.test.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues
Pull request (PR) checklist
package.jsonchanges have been explained to and approved by a repository managerTesting
The following manual testing was done:
The following was not tested:
Commit message guidelines
We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages: