Skip to content

feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, blokck nodes, mirror nodes and explorers #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 69 commits into
base: main
Choose a base branch
from
Draft

feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, blokck nodes, mirror nodes and explorers #1821

wants to merge 69 commits into from

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Apr 8, 2025 •
edited
Loading

Description

  • adds new command and command group block node with the class BlockNodeCommand

    • adds new sub-command for deploy used to install the block node official helm chart inside the specified cluster

  • Makes the remote config's components have unique names and helpers for generating them.

  • Adds wrapper classes and logic for creating commands with 3 levels of depth

    • Example: solo block node add

Related Issues

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

instamenta added 30 commits April 2, 2025 10:04
@instamenta
preparing new command BlockNodesCommand
6a29265 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fixed the interfaces for the new command, made the command flag defin…
c792f9d 
…ition, added the new flag about the block nodes chart version together with the initial constants

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
added new values file for block nodes and cleaned up the tasks
d03c7a2 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
add new command to command list and fix getCommandDefinition methods …
3aae36b 
…by using new types

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
remove unused code
fc213e8 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
set block nodes version to v7.0.0
612742d 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fixing issues with installing chart, urls and constants for new chart…
7a7661e 
… and initial setup for m4 apple chip compatibility

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…
cfef536 
…block-nodes-deploy

# Conflicts:
#	src/commands/base.ts
#	src/commands/flags.ts
#	src/core/constants.ts
@instamenta
adding new component block node to remote config, to keep track
ae621cf 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
added better names for ComponentsDataWrapper's methods, removed warni…
5c15994 
…ngs in the remote config related classes and worked on adding support for the new component type 'BlockNodeComponents'

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
checkpoint while refactoring components validation to reduce redundan…
9315010 
…cy and make it less error prone

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
refactored RemoteConfigValidator
6548a0e 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
add logic for creating the new block node component and figuring out …
7d9611e 
…the releaseName

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
rename 'block nodes' to 'block node' ( plural to singular )
1baf5f8 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
add 'nameOverride' for the block node chart and fix the logic for sup…
d42863b 
…porting m4 apple chips

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
moved each remote config enumerations into their individual own file …
3053fce 
…and renamed ComponentType to ComponentTypes to follow convention

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
adding new field state to the BaseComponent used inside the remote co…
7c98a59 
…nfig

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fixed typescript warnings and remote config component tests
ec669eb 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fix all unit tests
b500b87 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
added new logic for creating a component names with unique indexes
50e96f5 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
setting up new component creating for remote config
249e415 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…
129f367 
…block-nodes-deploy
@instamenta
transitioning block node command to use new remote config creation st…
d4382a1 
…rategy

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
created new methods for initiating remote config components, changed …
169be5c 
…codebase to use them, fixed most unit tests, todo: fix all tests, add new logic for editing remote components which should only work for consensus node's node state field

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
added new validation helper method
3b01f3a 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
set @typescript-eslint/explicit-function-return-type allowTypedFuncti…
8d90458 
…onExpressions to avoid having to have dublicated function return value difinitions

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
remove method editComponentState and add new method changeNodeState t…
07e92b9 
…o remote config

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
change remote config components data wrapper serviceName to component…
0e15c8f 
…Name

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
improve unit tests
7a46443 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…
ed3a6cc 
…block-nodes-deploy
@instamenta instamenta added the PR: Needs Team Approval A pull request that needs review from a team member. label Apr 8, 2025
@instamenta
improve logic for detecting apple m4 series chip, and add additional …
b8e54db 
…task that determines block node's health by checking it's health endpoint

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
uncomment important code
47eb933 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
switch remote component index counting to start from 0 instead of 1
edb0bb0 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
added 3 level nested command, and extended e2e test argv builder to s…
78b0365 
…upport it

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
added new classes for building 3 leveled command paths
fe13d3a 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fix block node e2e test
079c7dd 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta changed the title feat(block-node): implement 'solo block-node deploy' command and modify remote config to support multiple relays, blokck nodes, mirror nodes and explorers feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, blokck nodes, mirror nodes and explorers Apr 9, 2025
@instamenta instamenta requested a review from JeffreyDallas April 9, 2025 14:27
JeffreyDallas
JeffreyDallas previously approved these changes Apr 9, 2025
View reviewed changes
@instamenta instamenta added the PR: Needs Manager Approval A pull request that needs review from a manager. label Apr 10, 2025
@jeromy-cannon jeromy-cannon added PR: Checks Failed A pull request where the checks have failed. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. and removed PR: Checks Failed A pull request where the checks have failed. labels Apr 14, 2025
rbarker-dev
rbarker-dev previously approved these changes Apr 15, 2025
View reviewed changes
@instamenta
Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…
52f085d 
…block-nodes-deploy

# Conflicts:
#	src/core/config/remote/components/consensus-node-component.ts
#	src/core/config/remote/components/relay-component.ts
#	src/core/config/remote/remote-config-manager.ts
@instamenta instamenta dismissed stale reviews from rbarker-dev and JeffreyDallas via 52f085d April 15, 2025 07:36
@instamenta instamenta removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. PR: Needs Team Approval A pull request that needs review from a team member. labels Apr 15, 2025
@instamenta
update SOLO_CHART_VERSION
68246e5 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta added Blocked Further development work is blocked by other item and removed PR: Needs Manager Approval A pull request that needs review from a manager. labels Apr 16, 2025
@instamenta instamenta marked this pull request as draft April 16, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyDallas JeffreyDallas JeffreyDallas left review comments

@rbarker-dev rbarker-dev rbarker-dev left review comments

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

@nathanklick nathanklick Awaiting requested review from nathanklick

At least 1 approving review is required to merge this pull request.

Assignees

@instamenta instamenta

Labels
Blocked Further development work is blocked by other item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement solo block-nodes deploy
4 participants
@instamenta @JeffreyDallas @rbarker-dev @jeromy-cannon