feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, block nodes, mirror nodes and explorers #1821

instamenta · 2025-04-08T10:53:08Z

Description

adds new command and command group block node with the class BlockNodeCommand
- adds new sub-command for add used to install the block node official helm chart inside the specified cluster
Adds wrapper classes and logic for creating commands with 3 levels of depth
- Example: solo block node add

Related Issues

Closes # implement solo block-nodes deploy #1755

Pull request (PR) checklist

This PR added tests (unit, integration, and/or end-to-end)
This PR updated documentation
This PR added no TODOs or commented out code
This PR has no breaking changes
Any technical debt has been documented as a separate issue and linked to this PR
Any package.json changes have been explained to and approved by a repository manager
All related issues have been linked to this PR
All changes in this PR are included in the description
When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

This PR added unit tests
This PR added integration/end-to-end tests
These changes required manual testing that is documented below
Anything not tested is documented

Signed-off-by: Zhan Milenkov <[email protected]>

…ition, added the new flag about the block nodes chart version together with the initial constants Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…by using new types Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

… and initial setup for m4 apple chip compatibility Signed-off-by: Zhan Milenkov <[email protected]>

…block-nodes-deploy # Conflicts: # src/commands/base.ts # src/commands/flags.ts # src/core/constants.ts

Signed-off-by: Zhan Milenkov <[email protected]>

…ngs in the remote config related classes and worked on adding support for the new component type 'BlockNodeComponents' Signed-off-by: Zhan Milenkov <[email protected]>

…cy and make it less error prone Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…the releaseName Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…porting m4 apple chips Signed-off-by: Zhan Milenkov <[email protected]>

…and renamed ComponentType to ComponentTypes to follow convention Signed-off-by: Zhan Milenkov <[email protected]>

…nfig Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…block-nodes-deploy

…rategy Signed-off-by: Zhan Milenkov <[email protected]>

…codebase to use them, fixed most unit tests, todo: fix all tests, add new logic for editing remote components which should only work for consensus node's node state field Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…onExpressions to avoid having to have dublicated function return value difinitions Signed-off-by: Zhan Milenkov <[email protected]>

…o remote config Signed-off-by: Zhan Milenkov <[email protected]>

…Name Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…block-nodes-deploy

…block-nodes-deploy # Conflicts: # src/core/config/remote/components/consensus-node-component.ts # src/core/config/remote/components/relay-component.ts # src/core/config/remote/remote-config-manager.ts

Signed-off-by: Zhan Milenkov <[email protected]>

…block-nodes-deploy # Conflicts: # src/commands/explorer.ts # src/commands/mirror-node.ts # version.ts

Signed-off-by: Zhan Milenkov <[email protected]>

jeromy-cannon · 2025-04-24T13:53:42Z

eslint.config.mjs

@@ -137,7 +137,7 @@ export default [
        'warn',
        {
          allowExpressions: false,
-          allowTypedFunctionExpressions: false,
+          allowTypedFunctionExpressions: true,


jeromy-cannon · 2025-04-24T14:02:33Z

test/e2e/commands/block-node.test.ts

+      } catch (error) {
+        logger.showUserError(error);
+        expect.fail();
+      }


I think this is a good verification to add:

get-block.sh.txt
block_service.proto.txt

can you apply this to the block node destroy PR where the integration with consensus happens? I'm not sure what happens with block node for this test without consensus node actually integrated.

This is my original question that the image above was a response to:

What is the best way to see if Block Nodes is functional after Consensus Nodes are running?

jeromy-cannon · 2025-04-24T15:17:11Z

src/commands/flags.ts

+    name: 'block-node-version',
+    definition: {
+      describe: 'Block nodes chart version',
+      defaultValue: version.MIRROR_NODE_VERSION,


copy/paste error?

jeromy-cannon · 2025-04-24T15:17:38Z

src/commands/flags.ts

+      defaultValue: version.MIRROR_NODE_VERSION,
+      type: 'string',
+    },
+    prompt: async function promptMirrorNodeVersion(


copy/paste error?

jeromy-cannon · 2025-04-24T15:17:54Z

src/commands/flags.ts

+        Flags.mirrorNodeVersion.definition.defaultValue as boolean,
+        'Would you like to choose mirror node version? ',
+        null,
+        Flags.mirrorNodeVersion.name,


copy/paste error?

jeromy-cannon · 2025-04-24T15:22:11Z

src/commands/block-node.ts

+
+    if (isAppleM4SeriesChip) {
+      valuesArgument += helpers.populateHelmArguments({
+        'blockNode.config.JAVA_OPTS': '"-Xms8G -Xmx8G -XX:UseSVE=0"',


hmm... this won't work if we deploy to GKE, AWS, or Latitude from our MacOS laptops that have a M4 chip and they have overrode the min/max JVM size in the values file.

jeromy-cannon · 2025-04-24T15:24:31Z

src/commands/block-node.ts

+          task: async (context_): Promise<void> => {
+            const config: BlockNodeDeployConfigClass = context_.config;
+
+            config.isChartInstalled = await this.chartManager.isChartInstalled(


where is this being used?

jeromy-cannon · 2025-04-24T15:26:30Z

src/commands/block-node.ts

+    };
+  }
+
+  private displayHealthcheckData(


Suggested change

private displayHealthcheckData(

private displayHealthCheckData(

jeromy-cannon · 2025-04-24T15:27:19Z

src/commands/block-node.ts

+      task: async (context_, task): Promise<void> => {
+        const config: BlockNodeDeployConfigClass = context_.config;
+
+        const displayHealthcheckCallback: (


Suggested change

const displayHealthcheckCallback: (

const displayHealthCheckCallback: (

instamenta added 30 commits April 2, 2025 10:04

preparing new command BlockNodesCommand

6a29265

Signed-off-by: Zhan Milenkov <[email protected]>

fixed the interfaces for the new command, made the command flag defin…

c792f9d

…ition, added the new flag about the block nodes chart version together with the initial constants Signed-off-by: Zhan Milenkov <[email protected]>

added new values file for block nodes and cleaned up the tasks

d03c7a2

Signed-off-by: Zhan Milenkov <[email protected]>

add new command to command list and fix getCommandDefinition methods …

3aae36b

…by using new types Signed-off-by: Zhan Milenkov <[email protected]>

remove unused code

fc213e8

Signed-off-by: Zhan Milenkov <[email protected]>

set block nodes version to v7.0.0

612742d

Signed-off-by: Zhan Milenkov <[email protected]>

fixing issues with installing chart, urls and constants for new chart…

7a7661e

… and initial setup for m4 apple chip compatibility Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…

cfef536

…block-nodes-deploy # Conflicts: # src/commands/base.ts # src/commands/flags.ts # src/core/constants.ts

adding new component block node to remote config, to keep track

ae621cf

Signed-off-by: Zhan Milenkov <[email protected]>

added better names for ComponentsDataWrapper's methods, removed warni…

5c15994

…ngs in the remote config related classes and worked on adding support for the new component type 'BlockNodeComponents' Signed-off-by: Zhan Milenkov <[email protected]>

checkpoint while refactoring components validation to reduce redundan…

9315010

…cy and make it less error prone Signed-off-by: Zhan Milenkov <[email protected]>

refactored RemoteConfigValidator

6548a0e

Signed-off-by: Zhan Milenkov <[email protected]>

add logic for creating the new block node component and figuring out …

7d9611e

…the releaseName Signed-off-by: Zhan Milenkov <[email protected]>

rename 'block nodes' to 'block node' ( plural to singular )

1baf5f8

Signed-off-by: Zhan Milenkov <[email protected]>

add 'nameOverride' for the block node chart and fix the logic for sup…

d42863b

…porting m4 apple chips Signed-off-by: Zhan Milenkov <[email protected]>

moved each remote config enumerations into their individual own file …

3053fce

…and renamed ComponentType to ComponentTypes to follow convention Signed-off-by: Zhan Milenkov <[email protected]>

adding new field state to the BaseComponent used inside the remote co…

7c98a59

…nfig Signed-off-by: Zhan Milenkov <[email protected]>

fixed typescript warnings and remote config component tests

ec669eb

Signed-off-by: Zhan Milenkov <[email protected]>

fix all unit tests

b500b87

Signed-off-by: Zhan Milenkov <[email protected]>

added new logic for creating a component names with unique indexes

50e96f5

Signed-off-by: Zhan Milenkov <[email protected]>

setting up new component creating for remote config

249e415

Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…

129f367

…block-nodes-deploy

transitioning block node command to use new remote config creation st…

d4382a1

…rategy Signed-off-by: Zhan Milenkov <[email protected]>

added new validation helper method

3b01f3a

Signed-off-by: Zhan Milenkov <[email protected]>

set @typescript-eslint/explicit-function-return-type allowTypedFuncti…

8d90458

…onExpressions to avoid having to have dublicated function return value difinitions Signed-off-by: Zhan Milenkov <[email protected]>

remove method editComponentState and add new method changeNodeState t…

07e92b9

…o remote config Signed-off-by: Zhan Milenkov <[email protected]>

change remote config components data wrapper serviceName to component…

0e15c8f

…Name Signed-off-by: Zhan Milenkov <[email protected]>

improve unit tests

7a46443

Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…

ed3a6cc

…block-nodes-deploy

instamenta added the PR: Needs Manager Approval A pull request that needs review from a manager. label Apr 10, 2025

Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…

dcfa0bf

…block-nodes-deploy

jeromy-cannon added PR: Checks Failed A pull request where the checks have failed. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. and removed PR: Checks Failed A pull request where the checks have failed. labels Apr 14, 2025

rbarker-dev previously approved these changes Apr 15, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…

52f085d

…block-nodes-deploy # Conflicts: # src/core/config/remote/components/consensus-node-component.ts # src/core/config/remote/components/relay-component.ts # src/core/config/remote/remote-config-manager.ts

instamenta dismissed stale reviews from rbarker-dev and JeffreyDallas via 52f085d April 15, 2025 07:36

instamenta removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. PR: Needs Team Approval A pull request that needs review from a team member. labels Apr 15, 2025

update SOLO_CHART_VERSION

68246e5

Signed-off-by: Zhan Milenkov <[email protected]>

instamenta added Blocked Further development work is blocked by other item and removed PR: Needs Manager Approval A pull request that needs review from a manager. labels Apr 16, 2025

instamenta marked this pull request as draft April 16, 2025 12:25

jeromy-cannon added the P0 An issue impacting production environments or impacting multiple releases or multiple individuals. label Apr 22, 2025

instamenta added 6 commits April 24, 2025 09:50

Merge remote-tracking branch 'origin/main' into 01755-implement-solo-…

52c1baa

…block-nodes-deploy # Conflicts: # src/commands/explorer.ts # src/commands/mirror-node.ts # version.ts

fixes after merge

d938826

Signed-off-by: Zhan Milenkov <[email protected]>

removing rmeote config

8511154

Signed-off-by: Zhan Milenkov <[email protected]>

lint-fix

5b5f31a

Signed-off-by: Zhan Milenkov <[email protected]>

lint-fix and issues after reverting changes

ecbf3ed

Signed-off-by: Zhan Milenkov <[email protected]>

cleanup after removing remote config changes

864569e

Signed-off-by: Zhan Milenkov <[email protected]>

instamenta marked this pull request as ready for review April 24, 2025 12:51

instamenta requested review from a team as code owners April 24, 2025 12:51

instamenta removed the Blocked Further development work is blocked by other item label Apr 24, 2025

jeromy-cannon reviewed Apr 24, 2025

View reviewed changes

jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, block nodes, mirror nodes and explorers #1821

feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, block nodes, mirror nodes and explorers #1821

instamenta commented Apr 8, 2025 •

edited

Loading

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

jeromy-cannon Apr 24, 2025

	private displayHealthcheckData(
	private displayHealthCheckData(

	const displayHealthcheckCallback: (
	const displayHealthCheckCallback: (

feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, block nodes, mirror nodes and explorers #1821

Are you sure you want to change the base?

feat(block-node): implement 'solo block node add' command and modify remote config to support multiple relays, block nodes, mirror nodes and explorers #1821

Conversation

instamenta commented Apr 8, 2025 • edited Loading

Description

Related Issues

Pull request (PR) checklist

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

instamenta commented Apr 8, 2025 •

edited

Loading