VAULT-38848: make enos_bundle_install artifactory.username optional #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `artifactory.username` attribute for `enos_bundle_install` optional. We also deprecate the username attribute on the `data.enos_artifactory_item` to match the equivalent in `enos_bundle_install`. We also fixed a few formatting issues in rendered docs and updated optional nested attributes definitions. Co-Authored-by: Kelly Porter <[email protected]> Signed-off-by: Ryan Cragun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
artifactory.usernameattribute forenos_bundle_installoptional. We also deprecate the username attribute on thedata.enos_artifactory_itemto match the equivalent inenos_bundle_install.We also fixed a few formatting issues in rendered docs and updated optional nested attributes definitions.
How to read this pull request
You may provide an optional explanation of the best way a review might
approach the changes that are being proposed in this pull request.
Checklist