chore: 🤖 convert rose form to embroider safe component helper #3084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashicc
force-pushed
the
make-rose-form-embroider-safe
branch
from
ce51d78 to
bbb3c5b
Compare
Convert the component helper to use static strings which are embroider safe: https://github.com/embroider-build/embroider/blob/main/docs/replacing-component-helper.md
hashicc
force-pushed
the
make-rose-form-embroider-safe
branch
from
bbb3c5b to
a49f2bf
Compare
priya-patel04
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use conditional around the two different
{{component}}helper usages instead of one where the conditional is for the first string argument to the helper. This results in some redundancy for the args passed in but it makes the first argument for the{{component}}helper a static string and can therefore be statically analyzable by ember's build and is embroider-safe, see:https://github.com/embroider-build/embroider/blob/main/docs/replacing-component-helper.md
How to Test
showEditToggle=trueshow the correct'rose/form/actions/edit-toggle'component ("Edit Form" button) , otherwise'rose/form/actions'is shown ("Save" and "Cancel" button). Many forms use this case@showEditToggle={{if @model.isNew false true}}like the targets detail page.Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.