feat: 🎸 Add scope options component #3092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… of https://github.com/hashicorp/boundary-ui into ICU-18128-ui-create-component-permission-scope-options
cameronperera
requested changes
Dec 2, 2025
Collaborator
cameronperera
left a comment
cameronperera
left a comment
There was a problem hiding this comment.
Left a few comments but overall looks great!
| help: You can create aliases for this target that will make it easier to reach. Users must have access to this project to use aliases. | ||
| app-token: | ||
| title_plural: App Tokens | ||
| form: |
Collaborator
There was a problem hiding this comment.
non-blocking: With the plan to use this component for the scopes in a role, should we move these translations to the form translation file?
Collaborator
Author
There was a problem hiding this comment.
that's a good idea! thank u!
| if (this.args.model.scope.isGlobal) { | ||
| return 'Global'; | ||
| } | ||
| return this.args.model.scope.name ?? this.args.model.scope.id; |
Collaborator
There was a problem hiding this comment.
We should be able to use the displayName getter here.
Collaborator
Author
There was a problem hiding this comment.
oh yup good catch!
…ission-scope-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-18128
Description
Create scope options component that will be used for app-tokens and roles.
Screenshots (if appropriate)
Screen.Recording.2025-11-25.at.11.32.06.AM.mov
How to Test
Verify component works as expected by using unit test cases for the component.
Example usage:
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.