-
Notifications
You must be signed in to change notification settings - Fork 33
Admin vite spike #3095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hashicc
wants to merge
38
commits into
ember-mirage
Choose a base branch
from
admin-vite-spike
base: ember-mirage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Admin vite spike #3095
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b3f8d33
chore: 🤖 migrate away from component helper for target form
hashicc e4fcde1
chore: 🤖 migrate away from component helper for managed group
hashicc 40ace73
chore: 🤖 migrate away from component helper for host set form
hashicc 2e6a049
chore: 🤖 migrate component helper usage for storage bucket form
hashicc ce51d78
chore: 🤖 convert rose form to embroider safe component helper
hashicc e6367f9
chore: 🤖 bump ember-can
hashicc 447611e
chore: 🤖 import explicit mirage references
hashicc 48c4f3d
chore: 🤖 add mirage setupMirage helper
hashicc f067660
chore: 🤖 working example with application adapter test
hashicc f63822c
chore: 🤖 use internal setupMirage test helper from api addon
hashicc 3d77203
chore: 🤖 conditionally load mirage
hashicc 50cfcff
chore: 🤖 filter mirage folder inclusion in production builds
hashicc b397c8d
chore: 🤖 drop ember-mirage and use our own test helpers
hashicc 261c54f
chore: 🤖 collapse reference to import declaration
hashicc 65ba285
docs: ✏️ add comment better explaining the mirage test env
hashicc 242e4c1
chore: 🤖 update configuration and manage mirage-related deps
hashicc 7dae7f6
fix: 🐛 restore ipc mock and add missing checkOS handler
hashicc 93088ef
chore: 🤖 add comment explaining omitting mirage deps in build
hashicc 3a761c2
chore: 🤖 allow mirage.enabled to include deps and handlers
hashicc 4d00c7c
chore: 🤖 re-enable mirage for core dummy app
hashicc 5b89f08
Add missing copyright headers
hashicc f702feb
chore: 🤖 use embroider macros to conditionally start mirage
hashicc 69582d4
docs: ✏️ update api readme for mirage changes
hashicc 1dde116
chore: 🤖 replace remaining ember-cli-mirage references
hashicc 0ac968f
chore: 🤖 add mirage to test builds
hashicc 138fc2b
fix: 🐛 ensure that auto mirage start doesn't happen in test env
hashicc a0ff110
chore: 🤖 add ember-inflector
hashicc 0f2a401
chore: 🤖 add missing dependency on ember-inflector
hashicc 3ccfd55
chore: 🤖 rename "can" service (deprecated) to abilities
hashicc dbf3adf
chore: 🤖 add missing dependency on ember-inflector
hashicc 9d1be27
chore: 🤖 run codemode to vite
hashicc bafe813
Merge branch 'migrate-component-helper-target-form' into test-api-v2
hashicc 7a8f7a7
Merge branch 'migrate-component-helper-storage-bucket-form' into test…
hashicc 5dd564b
Merge branch 'migrate-component-helper-managed-group-form' into test-…
hashicc 2c28e61
Merge branch 'migrate-component-helper-host-set-form' into test-api-v2
hashicc b92cce1
Merge branch 'make-rose-form-embroider-safe' into test-api-v2
hashicc 79c96d1
chore: 🤖 hacky work to get vite working for admin
hashicc 9febf69
chore: 🤖 ember-engines
hashicc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,4 @@ export function confirm(confirmationTextKey, options) { | |
| }; | ||
| }; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,5 @@ export function debounce(timeToWait, options) { | |
| ); | ||
| }; | ||
| } | ||
|
|
||
| export default debounce; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,3 +116,5 @@ export function notifyError( | |
| }; | ||
| }; | ||
| } | ||
|
|
||
| export default notifySuccess; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -272,3 +272,5 @@ export function resourceFilter({ | |
| }; | ||
| }; | ||
| } | ||
|
|
||
| export default resourceFilter; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,7 @@ module.exports = { | |
| if (this.isDevelopingAddon()) app.options.svg.paths.push(dummyPublicPath); | ||
|
|
||
| this.addons.forEach((addon) => { | ||
| if (addon.name === 'ember-inline-svg') addon.included(app); | ||
| // if (addon.name === 'ember-inline-svg') addon.included(app); | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can probably be restored |
||
| }); | ||
| }, | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,14 +21,12 @@ | |
| data-test-code-editor-toolbar-menu-divider | ||
| ></div> | ||
| {{/if}} | ||
| <CopyButton | ||
| @text={{@copyText}} | ||
| @onSuccess={{this.copied}} | ||
| <div | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| class='rose-code-editor-toolbar__copy-button' | ||
| data-test-code-editor-toolbar-copy-button | ||
| > | ||
| <Hds::Icon @name={{this.copyIconType}} @isInline={{true}} /> | ||
| Copy code | ||
| </CopyButton> | ||
| </div> | ||
| </div> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to access the config here without this package and then restore usages to
environmentConfig