Skip to content

Icu 18506 load resource IDs for autocomplete#3247

Open
ZedLi wants to merge 3 commits intoICU-18462-add-initial-linting-to-code-editorfrom
ICU-18506-load-an-initial-resource-for-autocomplete
Open

Icu 18506 load resource IDs for autocomplete#3247
ZedLi wants to merge 3 commits intoICU-18462-add-initial-linting-to-code-editorfrom
ICU-18506-load-an-initial-resource-for-autocomplete

Conversation

@ZedLi
Copy link
Copy Markdown
Collaborator

@ZedLi ZedLi commented Apr 27, 2026

Description

Added logic to handle autocompletion of IDs loaded dynamically from the DB. You can search by both name and ID which are available filtered by the allowed scope IDs on the role.

Screenshots (if appropriate)

Screen.Recording.2026-04-27.at.4.05.49.PM.mov

How to Test

Go to the role you're testing and try different scopes on the role. Try editing grants and see what ids are available.

Checklist

  • I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@ZedLi ZedLi self-assigned this Apr 27, 2026
@ZedLi ZedLi requested a review from a team as a code owner April 27, 2026 20:12
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boundary-ui Ready Ready Preview, Comment Apr 28, 2026 9:13pm
boundary-ui-desktop Ready Ready Preview, Comment Apr 28, 2026 9:13pm

Request Review

}),
});
listToken = tokenObj?.token;
// Always prefer the global token when it exists for
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I was thinking of doing if we ever introduced global searching. With the loading of all resources for autocomplete, it's basically at that point. My main worry was the churn of loading the same resources but at different scopes.

For example, if i've loaded all targets from the global scope recursively already (i.e. all targets), do I need to re-load and hit the API for all scopes in a specific project? Ideally I should just re-use the global scope list token and check if there were any new ones and just the the sqlite DB properly filter down the right targets.

Let me know if you have any better ideas or thoughts/concerns about this pattern!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant