Icu 18506 load resource IDs for autocomplete#3247
Icu 18506 load resource IDs for autocomplete#3247ZedLi wants to merge 3 commits intoICU-18462-add-initial-linting-to-code-editorfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| }), | ||
| }); | ||
| listToken = tokenObj?.token; | ||
| // Always prefer the global token when it exists for |
There was a problem hiding this comment.
This is something I was thinking of doing if we ever introduced global searching. With the loading of all resources for autocomplete, it's basically at that point. My main worry was the churn of loading the same resources but at different scopes.
For example, if i've loaded all targets from the global scope recursively already (i.e. all targets), do I need to re-load and hit the API for all scopes in a specific project? Ideally I should just re-use the global scope list token and check if there were any new ones and just the the sqlite DB properly filter down the right targets.
Let me know if you have any better ideas or thoughts/concerns about this pattern!
1097d85 to
3fc93f8
Compare
3fc93f8 to
095dcca
Compare
Description
Added logic to handle autocompletion of IDs loaded dynamically from the DB. You can search by both name and ID which are available filtered by the allowed scope IDs on the role.
Screenshots (if appropriate)
Screen.Recording.2026-04-27.at.4.05.49.PM.mov
How to Test
Go to the role you're testing and try different scopes on the role. Try editing grants and see what ids are available.
Checklist
[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the descriptiona11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.