api/proxy: preserve active connections after auth failure - #6778
Draft
vigneshakaviki wants to merge 1 commit into
Draft
api/proxy: preserve active connections after auth failure#6778vigneshakaviki wants to merge 1 commit into
vigneshakaviki wants to merge 1 commit into
Conversation
An authorization rejection should stop new connections without canceling the shared proxy context used by connections that are already active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve active proxy connections when a new connection fails authorization. The authorization failure still closes the listener so no further connections can start, but it no longer cancels the shared context used by already-active connections.
Security-control impact: none. Authorization behavior remains unchanged; rejected connections still fail and stop the listener.
Closes #6774
Testing
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.