Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Add
consul.namespace
to helpers, allowing Consul resources to be deployed to a namespace other than.Release.Namespace
by setting theglobal.namespace
value.Derived from #3016 and credit to @0011blindmice.
How I've tested this PR:
Checked out 1.2.2 tag and cherry-picked the PR commits for helm package. Tested in KinD with no
global.namespace
specified, and with the config shown below.Helm Values
To verify backwards compatibility, the same values from above were supplied to
helm install consul hashicorp/consul --version 1.2.2 ...
. Subsequently runninghelm diff upgrade consul ./consul-1.2.2.tgz ...
, with the same values, returned no changes.How I expect reviewers to test this PR:
global.namespace
not in scope, but remains consistent with current expectation that.Release.Namespace
does not change after initial installation.Checklist: