Skip to content

Conversation

@shani34
Copy link

@shani34 shani34 commented Dec 23, 2025

Test cases fixes

  1. fixes related to dns
  • GKE-aware DNS handling: The code now detects GKE and uses stubDomains to extend DNS safely without breaking kube-dns behavior.
  • Clean config backups: Metadata like resourceVersion is stripped before restore, preventing conflicts during cleanup.
  • Correct DNS restarts: The right DNS deployment (coredns, kube-dns, or rke2-coredns) is detected and restarted to avoid stale DNS.
  1. Fixes related to Vault
  • Explicit pod CIDR allocation:
ip_allocation_policy.cluster_ipv4_cidr_block assigns a deterministic, non-overlapping pod IP range (10.100.0.0/14 split per cluster), which is critical for multi-cluster communication.
  • Expanded firewall source ranges:
source_ranges now allows traffic not only from the other cluster’s pod CIDR but also from its VPC subnet CIDR, ensuring pod-to-pod and node-level traffic works reliably across clusters.
  • Targeted firewall scoping:
target_tags restricts these firewall rules to only the Consul/K8s nodes, improving security while still enabling required cross-cluster traffic.

@shani34 shani34 marked this pull request as ready for review December 23, 2025 04:50
@shani34 shani34 requested a review from a team as a code owner December 23, 2025 04:50
@@ -0,0 +1,26 @@
name: pr-cloud-acceptance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workflow was removed as public cloud workflows were inconsistent, let's not add it until all those issues are resolved. I think this was needed for GKE tests, but please remove this workflow for now. Let's add it back after all cloud tests issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants