Skip to content

Comments

Update datadog.mdx#22077

Closed
natemollica-nm wants to merge 2 commits intomainfrom
natemollica-nm-patch-3
Closed

Update datadog.mdx#22077
natemollica-nm wants to merge 2 commits intomainfrom
natemollica-nm-patch-3

Conversation

@natemollica-nm
Copy link
Contributor

Description

Reword the end user note to be in an English-understandable format.

Original

Currently, the annotations configured by the Helm overrides with Consul RPC TLS enabled assume server and ca certificate secrets are shared with the Datadog agent release namespace and mount the valid tls.crt, tls.key, and ca.crt secret volumes at the /etc/datadog-agent/conf.d/consul.d/certs path on the Datadog Agent, agent container.

Update

Currently, the annotations configured by the Helm overrides, when Consul RPC TLS is enabled, presume the user has shared the server and ca certificate secrets with the Datadog agent's Kubernetes namespace and mount the valid tls.crt, tls.key, and ca.crt secret volumes at the /etc/datadog-agent/conf.d/consul.d/certs path within the Datadog Agent pod's agent container.

Testing & Reproduction steps

  • N/A

Links

  • N/A

PR Checklist

  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Reword the end user note to be in an English-understandable format.
@natemollica-nm natemollica-nm added the type/docs Documentation needs to be created/updated/clarified label Jan 16, 2025
@natemollica-nm natemollica-nm requested a review from a team as a code owner January 16, 2025 00:11
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.20 Changes are backported to 1.20 labels Jan 16, 2025
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this confusing note!

I left some additional suggestions to help clarify these sentences and align with our style guide! Please implement the suggestions and then I will approve you to merge!

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Mar 18, 2025
@natemollica-nm natemollica-nm enabled auto-merge (squash) March 19, 2025 14:58
@github-actions
Copy link

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Apr 17, 2025
auto-merge was automatically disabled April 17, 2025 01:34

Pull request was closed

@github-actions github-actions bot deleted the natemollica-nm-patch-3 branch August 29, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.20 Changes are backported to 1.20 meta/stale Automatically flagged for inactivity by stalebot pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants