Upgrade to using hashicorp/go-metrics@v0.5.4

[mkeeler]

Description

Migrate Consul to using hashicorp/go-metrics instead of armon/go-metrics.

This necessarily includes updates to the following dependencies:

• raft
• raft-boltdb/v2
• raft-wal
• memberlist
• serf

All of those libraries were previously updated to support compatibility with hashicorp/go-metrics. In order to get the metrics for those libraries flowing out to hashicorp/go-metrics, I added the hashicorpmetrics build tag.

This should be a non-functional change but unblocks future go-metrics updates.

I also bumped the serf and memberlist dependencies within the api module. While that module doesn't cause any metrics to be invoked, I wanted to ensure only the latest versions with metrics compatibility would be directly relied upon.

Note that armon/go-metrics still appears as an indirect dependency in go.mod. This is because of a new compat package within hashicorp/go-metrics that allow for swapping the underlying metrics module used between armon/go-metrics and hashicorp/go-metrics with the build tag.

Testing & Reproduction steps

• make dev-build
• mkdir data
• `consul agent -server -data-dir $(pwd)/data -bind 127.0.0.1 -bootstrap -hcl 'raft_logstore { backend = "boltdb" }'
• curl localhost:8500/v1/agent/metrics and then verify metrics are present from raft, raft-boltdb/v2, memberlist and serf.
• Stop the Consul server
• rm -rf data/* to wipe the data directory
• `consul agent -server -data-dir $(pwd)/data -bind 127.0.0.1 -bootstrap
• curl localhost:8500/v1/agent/metrics and then verify metrics are present from raft, raft-wal, memberlist and serf.

In my own testing I have verified that at least one metric from all the affected libraries are still emitted correctly along with normal Consul metrics.

Note the agent is run twice with the different raft log stores to ensure both metrics from boltdb or the WAL are being emitted

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[promiseofcake]

What can we do to get this landed? Downstream transitive consumers are blocked due to the repo ownership change.

[github-actions]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[jrh3k5]

Giving this a nudge - I'm unable to update to v0.5.4 of hashicorp/go-metrics due to a transitive dependency on armon/go-metrics by the hashicorp/consul/api Go module.

[qwenode]

go: github.com/armon/go-metrics@v0.4.2: parsing go.mod:
module declares its path as: github.com/hashicorp/go-metrics
but was required as: github.com/armon/go-metrics
restoring github.com/armon/go-metrics@v0.4.1

[github-actions]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[github-actions]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.