Adds handling for RFC 9156#22095
Closed
ncode wants to merge 3 commits intohashicorp:mainfrom
ncode:juliano/dns_qname
Closed
Adds handling for RFC 9156#22095ncode wants to merge 3 commits intohashicorp:mainfrom ncode:juliano/dns_qname
ncode wants to merge 3 commits intohashicorp:mainfrom
ncode:juliano/dns_qname
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing #6579 by adding qname minimization handling based on rfc9156
This pull request includes improvements to the DNS handling in the
agentpackage, specifically focusing on QNAME minimization as per RFC 9156. The changes include handling partial domain queries and updating the related tests.Improvements to DNS handling:
.changelog/22095.txt: Added a release note indicating the improvement in DNS handling based on RFC 9156.agent/dns.go: Reordered imports for better organization and added handling for potential QNAME minimization queries, returning empty responses for partial domain components. [1] [2]Updates to tests:
agent/dns_test.go: Removed some invalid query tests and added new tests for QNAME minimization, ensuring partial queries return empty success and full queries return actual records. [1] [2]Links
https://www.rfc-editor.org/rfc/rfc9156.txt
PR Checklist