Conversation
pajay-rao
added
pr/no-changelog
Go Test Coverage: 69.7%See the workflow run for the full per-package breakdown and downloadable HTML report. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23842 +/- ##
==========================================
+ Coverage 61.00% 64.15% +3.14%
==========================================
Files 781 970 +189
Lines 99386 119921 +20535
==========================================
+ Hits 60631 76933 +16302
- Misses 32615 35814 +3199
- Partials 6140 7174 +1034 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
srahul3
previously approved these changes
Aug 26, 2026
srahul3
left a comment
srahul3
left a comment
Collaborator
There was a problem hiding this comment.
✅ LGTM form architecture standpoint. Take care of few nit
| return sd | ||
| } | ||
|
|
||
| // TODO: handle this with mog |
Collaborator
There was a problem hiding this comment.
NIT: do we need to implement something to be picked by mog?
| return a | ||
| } | ||
|
|
||
| // TODO: handle this with mog |
Collaborator
There was a problem hiding this comment.
NIT: do we need to implement something to be picked by mog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CAMP feature structs backport
Testing & Reproduction steps
pajayrao@pajayrao-HGG7QH6XVN minion-chat-advance % consul services register 105-camp-end-to-end-local/camp-apps/services/ai-app.hcl Error: service "ai-app": 1 error occurred: * ai is ent only featureLinks
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.