state: do not treat short hex node names as UUID prefixes - #23865
Open
ShravanthReddy wants to merge 1 commit into
Open
state: do not treat short hex node names as UUID prefixes#23865ShravanthReddy wants to merge 1 commit into
ShravanthReddy wants to merge 1 commit into
Conversation
On a name miss, nodeServices treated any 2+ character hex query as a
UUID prefix. resizeNodeLookupKey("ba1") is "ba", so NodeServices("ba1")
returned an unrelated node whose ID started BA. Require an 8-character
prefix after resize.
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NodeServices("ba1")can return an unrelated node.Root Cause
On a name miss the catalog does a UUID prefix lookup.
minUUIDLookupLenis 2, andresizeNodeLookupKey("ba1")isba, so any node whose ID startsBA…matches.Fix
Require 8 hex characters after resize before treating the query as a UUID prefix. A missing short hex name returns nothing. Existing UUID and prefix lookups are unchanged.
Testing
go test ./agent/consul/state -run 'TestStateStore_NodeServices' -count=1Fixes #23724