-
Notifications
You must be signed in to change notification settings - Fork 51
FlightIcon pipeline - FigmaApi updates #2543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues in my testing.
tokens seems ok 👍
flight-icons not so much:
- type checking fails (
yarn run typecheck) - syncing (
yarn run sync) fails with my local token (error below) resulting in removing all icons; this could be a 'me' issue
Removing "svg-original" output folder
Retrieving assets metadata via REST API
[AxiosError: Request failed with status code 403]
@alex-ju I'll see what I can do (they were there also before this PR)
@alex-ju do you have a |
it works well for me in
yes, I have a local token setup, tested with it before, but maybe something changed in my permissions (my Figma account often gets downgraded to view only); if you tested |
alternatively, we can run the associated GitHub Action using this branch, and see if it opens a PR (and then close it)
|
|
Currently investigating why the GH action failed (as in @alex-ju local env) but it works in my local environment 🤔 |
|
OK, mystery solved. All good, we can merge. |


📌 Summary
Figma will soon retire the old OAuth endpoints for their Figma REST API (February 24, 2025).
This PR accounts for the changes to the underlying
figma-apilibrary (maintained by @didoo) and takes the opportunity to update also some related dependencies.Notice:
2.0of thefigma-apihas been tested locally and it works as expectedfigma-exportto the latest version, but the script compilation was throwing an error (related torequirevsimport) so I decided to skip this update.🛠️ Detailed description
In this PR I have:
typescriptto5.6.3(latest) in bothflight-iconsandtokenspipelines (to keep them in sync)ts-nodeto10.9.2(latest) inflight-iconspipeline@types/nodeto22.8.7(latest) in bothflight-iconsandtokenspipelines (to keep them in sync)figma-apito2.0.1-betainflight-iconspipelinefigma-apiendpoint calls in our code to use the new format🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-4103
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.