Web Docs - SuperSelect::Multiple guidance updates
#2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
website/docs/components/form/super-select/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
Contributor
KristinLBradley
left a comment
KristinLBradley
left a comment
There was a problem hiding this comment.
Added one suggestion for improving clarity but looks good otherwise.
…guidelines.md Co-authored-by: Kristin Bradley <[email protected]>
KristinLBradley
previously approved these changes
Apr 15, 2025
jorytindall
previously approved these changes
Apr 15, 2025
Contributor
jorytindall
left a comment
jorytindall
left a comment
There was a problem hiding this comment.
Just left one small non-blocking comment
website/docs/components/form/super-select/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
…guidelines.md Co-authored-by: Jory Tindall <[email protected]>
majedelass
dismissed stale reviews from jorytindall and KristinLBradley
via
72c52aa
Contributor
Author
|
@jorytindall @KristinLBradley sorry the updates staled the reviews. Can you give it another approval? |
jorytindall
previously approved these changes
Apr 15, 2025
heatherlarsen
requested changes
Apr 15, 2025
...te/public/assets/components/form/super-select/super-select-before-options-custom-content.png
Show resolved
Hide resolved
website/public/assets/components/form/super-select/super-select-dont-visually-heavy.png
Show resolved
Hide resolved
website/public/assets/components/form/super-select/super-select-flow-clear-selected.png
Show resolved
Hide resolved
website/public/assets/components/form/super-select/super-select-flow-select-all.png
Show resolved
Hide resolved
website/public/assets/components/form/super-select/super-select-multiple-variant.png
Show resolved
Hide resolved
Contributor
Author
|
@heatherlarsen The reason why the total count was not included in those screen shots was because it's an optional argument. This was left over from the previous iteration of the docs. I will add them in for consistency's sake. |
jorytindall
previously approved these changes
Apr 15, 2025
zamoore
previously approved these changes
Apr 15, 2025
majedelass
dismissed stale reviews from zamoore, heatherlarsen, and jorytindall
via
0346b7a
zamoore
approved these changes
Apr 16, 2025
jorytindall
approved these changes
Apr 16, 2025
heatherlarsen
approved these changes
Apr 16, 2025
KristinLBradley
approved these changes
Apr 17, 2025
shleewhite
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will update the guidance portion of the SuperSelect docs to reflect the changes coming for the
SuperSelect::Multiplecomponent.🛠️ Detailed description
Some key items to be aware of:
SuperSelect::Multiplenow includes a "X selected" text for consistent context for the user.🔗 External links
Jira ticket: HDS-4748
Figma file: Link
💬 Please consider using conventional comments when reviewing this PR.