Form::SuperSelect::Multiple: Implement updated designs
#2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
majedelass
previously approved these changes
Apr 16, 2025
Contributor
majedelass
left a comment
majedelass
left a comment
There was a problem hiding this comment.
👏 This is fantastic!!! Everything fits the exact specifications, really good job 🎊
dchyun
reviewed
Apr 16, 2025
Contributor
dchyun
left a comment
dchyun
left a comment
There was a problem hiding this comment.
Really cool improvement on what was existing. Just spotted one small style thing.
packages/components/src/styles/components/form/super-select.scss
Outdated
Show resolved
Hide resolved
dchyun
previously approved these changes
Apr 16, 2025
Co-authored-by: Dylan Hyun <[email protected]>
shleewhite
force-pushed
the
hds-4756/super-select-design-update
branch
from
a108075 to
727a1cf
Compare
dchyun
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would update the design of the multiselect super select to improve the experience when many items are selected.
📸 Screenshots
Before
After
🔗 External links
Jira ticket: HDS-4756
Figma file: Final updated designs
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.