-
Notifications
You must be signed in to change notification settings - Fork 51
CodeBlock - height toggle feature (HDS-4745)
#2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
5f5f712
HDS-4745 Implement height toggle functionality, add basic styling, up…
KristinLBradley acf985f
HDS-4745 Add changeset
KristinLBradley 432d802
HDS-4745 Add tests for heigh toggle feature
KristinLBradley 4cb4870
HDS-4745 Fix issue with determining height of content with container …
KristinLBradley 3be6dc8
HDS-4745 Add gradient that appears behin Show more button, refactor r…
KristinLBradley 8c1695e
HDS-4745 Fix linting error
KristinLBradley 53797c0
HDS-4745 Tweak height of gradient to match visual design, remove bott…
KristinLBradley ce6896b
HDS-4745 Make border of numbering extend to bottom of code block
KristinLBradley 65e6a79
HDS-4745 Fix linting, change height toggle button to secondary color
KristinLBradley b517c12
HDS-4745 Implement dark button styles following copy button
KristinLBradley 52eed80
HDS-4745 Fix issue with numbering border on expanded CodeBlock
KristinLBradley 5305191
HDS-4745 Fix interactivity when hovering overlay footer, undo & clean…
KristinLBradley 72ae18e
HDS-4745 Tweak padding and positioning styles for overlay footer and …
KristinLBradley 0b61f8a
Fix: Refactor toggle button to prevent focus being lost
dchyun 163e5f6
Feat: Update toggle icon and label
dchyun d992568
Fix: Footer padding alignment to design
dchyun d33b796
Fix: Remove footer styles affecting line highlighting
dchyun f5b3444
Fix: Remove comments
dchyun 634b674
Fix: Linting
dchyun feab0fe
Fix: Footer gradient positioning
dchyun b348338
Guidelines update
andgen404 3833ae4
Fix: Revert guidelines update
dchyun bb8309b
Fix: Update expanded state class name
dchyun 668aace
Fix: Footer gradient horizontal overflow
dchyun f0f7ddc
Fix: Linting
dchyun a8a8df0
Fix: Horizontal overflow gradient placement and code block spacing
dchyun 000dbea
Fix: Gradient horizontal scrolling
dchyun 863346b
Fix: Gradient overflow, line numbers border
dchyun 5dfc2ae
Fix: scss variable syntax
dchyun 4ad22e6
Fix: Line wrapping with long string
dchyun d65b2a4
Chore: Style clean up, add comments
dchyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": minor | ||
| --- | ||
|
|
||
| `CodeBlock` - Added height toggle control which is present when a `maxHeight` is set and code content height exceeds the `maxHeight` value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.