-
Notifications
You must be signed in to change notification settings - Fork 51
Tag - Prevent inheritance overrides for font styles
#2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
Tag - Tag - Fix infinite adding and removing of overflow tooltip
๐ฆ RC Packages PublishedLatest commit: d546836 |
|
@dchyun maybe it would be worth to add a specific test/example to the showcase, to make sure there are no regressions in the future and this use case is correctly covered? (see for example how it's done in the Tooltip or RichTooltip) |
@didoo Thanks for the suggestion. Added an inheritance section into the showcase page. |
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but I think I may have found the root problem.
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comment, everything is minor.
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tag - Fix infinite adding and removing of overflow tooltipTag - Prevent inheritance overrides for font styles
๐ Summary
This PR fixes an issue with the
Tagwhere when the text is at a specific character length, the overflow tooltip is infinitely added and removed.๐ ๏ธ Detailed description
This issue was originally observed in Atlas. Where when applying filters to the organization run page, the tooltip button that is added when a tag's text goes beyond a max width, was being infinitely added and removed causing the tag to flash back and forth.
This issue is caused by the fact that the font of the tag's text is changing from when it is not overflowing and using a
spanvs. when it is overflowing and using abuttonelement from theHds::TooltipButton.In atlas there is a different default font used for
buttonelements, that does not align to theHDSdefault font. This was causing the following cycle.Setting
font: inherit;insures that all fonts are standardized when both thebuttonelement andspanelement is used.Steps to reproduce in Atlas
/settings/runspage.External Link
๐ Component checklist
๐ฌ Please consider using conventional comments when reviewing this PR.