fix(components): LinkToExternal & make ember-engines optional
#2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 RC Packages PublishedLatest commit: 368e18a |
Collaborator
Author
|
tested on:
|
aklkv
force-pushed
the
fix/link-to-external-retake
branch
from
ce4d62b to
fcce025
Compare
MelSumner
changed the title
LinkToExtrnal & make ember-engines optionalLinkToExternal & make ember-engines optional
aklkv
force-pushed
the
fix/link-to-external-retake
branch
from
fcce025 to
a793c95
Compare
RobbieTheWagner
previously approved these changes
Apr 28, 2025
zamoore
previously approved these changes
Apr 30, 2025
| "ember-source": "^3.28.0 || ^4.0.0 || ^5.3.0", | ||
| "ember-engines": ">= 0.11.0" | ||
| }, | ||
| "peerDependenciesMeta": { |
Contributor
There was a problem hiding this comment.
Just to be safe, did you try to install on a codebase without ember-engines?
aklkv
force-pushed
the
fix/link-to-external-retake
branch
from
a05ea54 to
aea7856
Compare
zamoore
approved these changes
May 1, 2025
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Today we are referencing
<LinkToExternal/>component and in the many cases it doesn't exists unless consumer hasember-enginesas dependancy. In theembroider/viteworld all components are evaluated at the build time and needs to resolve correct dependancy. If we were to runhdsembroider/vite today it would result in an error about unresolvedLinkToExternalcomponent. In order to make this behaviour more controlled we are encapsulating requirements forember-enginesto be explicitly required only in situation when we pass@isRouteExternalastruein which case we do our check for required dependancy resigne component instance or through an error.Shipping
ember-enginesis not an option for a couple of reasons:🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.