-
Notifications
You must be signed in to change notification settings - Fork 48
HDS Docs
- Breakpoints
#2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDS Docs
- Breakpoints
#2855
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice first pass! There is some inconsistent language usage that I tried to catch, and I added some suggestions for expressing some of that content in more plain language. Whether these accurately express what you're trying to say, TBD! But take what you feel is relevant from them.
website/docs/foundations/breakpoints/partials/guidelines/overview.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/overview.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/foundations/breakpoints/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
@jorytindall @shleewhite @KristinLBradley @dchyun I had to push a couple of extra commit, any of you can re-approve? thanks |
website/docs/foundations/breakpoints/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
|
||
### JavaScript | ||
|
||
We also provide helpers in case you need to access the breakpoints names/values in JavaScript code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Question, non-blocker) How often do we expect this to happen? Should the language reflect whether or not this is a good idea? In other places we've said things like, "should you need to" which is more of an indicator that it's there but use with caution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing "dangerous" in them using the breakpoints in JS, it depends on the context where they need it (meet them where they are). There are use cases where controlling responsive behaviour in JS is inevitable (and in fact, that's what we do ourselves in the AppHeader and AppSideNav/SideNav components).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion to make something less wordy but no blockers.
Co-authored-by: Melanie Sumner <[email protected]>
website/docs/components/app-side-nav/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
@didoo please update the base of this to the new |
The base branch was changed.
@dchyun done. I need re-approval now. |
📌 Summary
If merged, this PR will add a new section within the Foundations section for Breakpoints.
Preview: https://hds-website-git-breakpoints-hashicorp.vercel.app/foundations/breakpoints
🛠️ Detailed description
Following the work done for the memo describing what path we are taking and what comes next, this PR is to create the new section describing the different breakpoints, their application and how to design uses these standards.
🔗 External links
Memo: Standardizing Breakpoints
Jira ticket: HDS-4831
Figma file: Breakpoints project
💬 Please consider using conventional comments when reviewing this PR.