Skip to content

AdvancedTable - add @maxHeight argument and fix the container styles #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

AdvancedTable - add @maxHeight argument and fix the container styles #2865

merged 6 commits into from
May 14, 2025

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented May 9, 2025 •
edited
Loading

📌 Summary

If merged, this PR would:

  • add a maxHeight argument. If it is set, hasStickyHeader is automatically set to true.
  • add a check that if hasStickyHeader is true, the consumer has to set @maxHeight
  • update the showcase

Showcase preview

🔗 External links

Jira ticket: HDS-4751

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@shleewhite shleewhite requested review from a team as code owners May 9, 2025 20:48
@vercel Vercel
Copy link

vercel bot commented May 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 14, 2025 5:25pm
hds-website ✅ Ready (Inspect) Visit Preview May 14, 2025 5:25pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website showcase labels May 9, 2025
KristinLBradley
KristinLBradley previously approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just added a suggestion for the changelog format

@shleewhite shleewhite requested a review from a team May 13, 2025 17:08
didoo
didoo reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but nothing major. Ready to approve, once you are OK with the code.

@shleewhite shleewhite added this to the [email protected] milestone May 14, 2025
@shleewhite shleewhite force-pushed the hds-4751/advanced-table-height branch from 7754730 to ba081cf Compare May 14, 2025 16:49
@hashibot-hds hashibot-hds removed the docs-website Content updates to the documentation website label May 14, 2025
@shleewhite shleewhite requested review from didoo, KristinLBradley and a team May 14, 2025 17:22
didoo
didoo approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shleewhite shleewhite merged commit b724dbd into main May 14, 2025
16 checks passed
@shleewhite shleewhite deleted the hds-4751/advanced-table-height branch May 14, 2025 18:14
@hashibot-hds hashibot-hds mentioned this pull request May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo approved these changes

@KristinLBradley KristinLBradley KristinLBradley approved these changes

Assignees
No one assigned
Labels
packages/components showcase
Projects
None yet
Milestone
[email protected]
Development

Successfully merging this pull request may close these issues.
4 participants
@shleewhite @didoo @KristinLBradley @hashibot-hds