Update ember-a11y-testing dependency in showcase and website
#2921
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
changed the title
|
@MelSumner any thoughts? |
|
also why a11y tests aren't running in CI 🤔 @hashicorp/hds-engineering ? |
|
@aklkv this one slipped through my radar, I have it on my todo list for today though. |
We run them on the showcase, look in the acceptance tests there. That way we can test all iterations of the component for a11y at the same time. It's also in the guidance for the @hashicorp/hds-engineering team to checking the component as it is built; occasionally something will slip through but it doesn't happen very often. |
| let module; | ||
| try { | ||
| module = importSync(`/docs/${this.args.componentId}.js`); | ||
| module = importSync(`./docs/${this.args.componentId}.js`); |
There was a problem hiding this comment.
(question) is this related to the other changes made in this PR?
There was a problem hiding this comment.
non, not at all, it was just something that keeps coming up if I pnpm dedupe, totally unrelated
|
@alex-ju question: why are consumers being touched by this at all actually? They should only be getting HDS and I don't see it as a dep (or even a devDep) of the components. |
MelSumner
changed the title
ember-a11y-testing dependency in showcase and website
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
MelSumner
left a comment
MelSumner
left a comment
There was a problem hiding this comment.
Note: updated the PR title to reflect changes made in the PR.
I'll file a couple of Jira issues to confirm what is or is not happening in CI, and to double-check the compliance of the components themselves.
aklkv
force-pushed
the
spike/a11y-dropdown-issue
branch
from
e06fe12 to
f99ae6a
Compare
aklkv
force-pushed
the
spike/a11y-dropdown-issue
branch
from
f99ae6a to
49df96c
Compare
MelSumner
left a comment
MelSumner
left a comment
There was a problem hiding this comment.
@hashicorp/hds-engineering still have a flaky test going on
they're not. I believe @aklkv wanted to make sure we use the latest |
|
initial goal of this PR was to showcase some failing a11y tests if consumers use latest a11y-testing but yes we ended up repurposing this PR us dependancy bump as it's anyway needed for ember 6.4 in #2901 |
4 participants
📌 Summary
This is mainly a proof that a11y is testing on consumer side. This is now blocking ember 6.4 upgrades. I raised this issue some time ago but unable to fide slack thread.
Here is
cloud-uiPR with failing a11y tests, it seems that they are mainly around dropdown and specifically colour contrast https://github.com/hashicorp/cloud-ui/pull/11711[side-note]: given this loose range it is quite fragile on any consumer side. e.g. if I ran
pnpm dedupeit will bumpaxe-corein cloud-ui leading to broken tests. tho I am not sure we can do anything about it other then open issue upstream saying that adding new violations to patch or minor version is problematic. Potentially we can pinaxe-coreon consumer side, also as long term solution ember-a11y-testing can moveaxe-coreto peerDeps and specify range so that consumer control which version to use and upgrade at it's own pace, this is more flexible at addon it self has to release version addressing other compatibility issues and ifaxe-coreis closely tide to addon version it can lead to blockers🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.