CodeBlock - Make didInsertNode arguments optional
#2924
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 RC Packages PublishedLatest commit: 0c66a92 Published 2 packages@hashicorp/[email protected]@hashicorp/[email protected] |
didoo
reviewed
Jun 3, 2025
Comment on lines
+187
to
+190
| schedule('afterRender', (): void => { | ||
| const titleElement = this._element.querySelector( | ||
| TITLE_ELEMENT_SELECTOR | ||
| ) as HTMLElement; |
Contributor
There was a problem hiding this comment.
[question] was this the only way? I am a bit nervous about using DOM querySelector methods inside controllers, looks a bit contrary to what we should do.
@zamoore thoughts?
Contributor
Author
There was a problem hiding this comment.
It's similar to an approach used in the Stepper::Nav. I had to use a querySelector approach since when the element was being passed in it was causing the other type issues.
From the nav:
@action
didInsertStep(): void {
// eslint-disable-next-line ember/no-runloop
schedule('afterRender', (): void => {
this.updateSteps();
});
}
private updateSteps(): void {
const steps = this._element.querySelectorAll(STEP_ELEMENT_SELECTOR);
...
Contributor
|
@dchyun can you add an explanation of why it was closed, and link to the other PR? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged this PR would make the
didInsertNodearguments for the contextualTitleandDescriptioncomponents optional to avoid any errors thrown in consumer repos by adding them as required arguments in #2879.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.