Skip to content

Conversation

@dchyun
Copy link
Contributor

@dchyun dchyun commented Jun 3, 2025

📌 Summary

If merged this PR would update the CodeBlock signature to use WithBoundArgs instead of ComponentLike. This is to avoid any errors thrown in consumer repos by having required arguments in the Title and Description contextual components, which came from #2879.

These issues were originally caught in the release 4.20 smoke testing.


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 3, 2025 5:29pm
hds-website ✅ Ready (Inspect) Visit Preview Jun 3, 2025 5:29pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

📦 RC Packages Published

Latest commit: cf640e3

Published 2 packages

@hashicorp/[email protected]

yarn up -C @hashicorp/design-system-components@rc

@hashicorp/[email protected]

yarn up -C @hashicorp/flight-icons@rc

@dchyun dchyun removed the release-candidate Publishes release candidates to npm label Jun 3, 2025
@dchyun dchyun marked this pull request as ready for review June 3, 2025 18:07
@dchyun dchyun requested a review from a team as a code owner June 3, 2025 18:07
@dchyun dchyun merged commit 5c1ada7 into main Jun 3, 2025
23 of 24 checks passed
@dchyun dchyun deleted the dchyun/code-block-signature-update branch June 3, 2025 18:10
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants