Skip to content

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Jun 4, 2025

📌 Summary

In #2864 I made some changes and fixes to the changeset entries, but they're now gone (the PR is re-generated and the previous commits are lost, probably because of a forced push)

So I'm opening this PR to edit directly the source files.

@alex-ju @dchyun see comment https://hashicorp.atlassian.net/wiki/spaces/HDS/pages/3511910428/Release+Procedure?focusedCommentId=4027711557


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@didoo didoo requested a review from dchyun June 4, 2025 18:29
@didoo didoo requested a review from a team as a code owner June 4, 2025 18:29
@vercel
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 4, 2025 7:34pm
hds-website ✅ Ready (Inspect) Visit Preview Jun 4, 2025 7:34pm

`AppHeader` - Removed usage of `--hds-app-desktop-breakpoint` CSS variable and relied on the `@breakpoint` argument for override of mobile behavior

`AppSideNav` - Removed usage of `--hds-app-desktop-breakpoint` CSS variable, added `@breakpoint` argument, and relied on it for override of mobile behaviour
`AppSideNav` - Removed usage of `--hds-app-desktop-breakpoint` CSS variable, added `@breakpoint` argument, and relied on it for override of mobile behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇺🇸 🇺🇸 🇺🇸

@didoo didoo merged commit bbefe2f into main Jun 4, 2025
10 checks passed
@didoo didoo deleted the changeset-entries-tweaks branch June 4, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants