Skip to content

Conversation

@aklkv
Copy link
Collaborator

@aklkv aklkv commented Nov 4, 2025

πŸ“Œ Summary

πŸ› οΈ Detailed description

πŸ“Έ Screenshots

πŸ”— External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@aklkv aklkv self-assigned this Nov 4, 2025
@aklkv aklkv requested a review from a team as a code owner November 4, 2025 04:05
@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Nov 4, 2025 6:26pm
hds-website Ready Ready Preview Nov 4, 2025 6:26pm

shleewhite
shleewhite previously approved these changes Nov 4, 2025
test('Components/layout/grid page passes automated a11y checks', async function (assert) {
await visit('/components/layout/grid');
test('Layout/grid page passes automated a11y checks', async function (assert) {
await visit('/layouts/grid');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can supress the color contrast errors for now, you just need to add:

let axeOptions = {
      rules: {
        'color-contrast': {
          enabled: false,
          selectors: [['.shw-placeholder']],
        },
      },
    };

and pass that to a11yAudit

@aklkv aklkv merged commit d9c1879 into main Nov 4, 2025
16 checks passed
@aklkv aklkv deleted the fix/layout-grid-acceptante-test branch November 4, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants