DialogPrimitiveBody - revert change to tabindex (HDS-5585)
#3350
+1
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
approved these changes
Nov 4, 2025
There was a problem hiding this comment.
Can you please:
- create a Jira ticket for this
- add references to the PR description and the new Jira ticket (Slack thread, Cloud UI smoke testing PR https://github.com/hashicorp/cloud-ui/pull/13235, original PR and Jira tickte)
- link the new and the old Jira ticket
KristinLBradley
changed the title
DialogPrimitiveBody - revert change to tabindexDialogPrimitiveBody - revert change to tabindex (HDS-5585)
KristinLBradley
deleted the
revert-dialog-primitive-body-tab-index-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR reverts the change to the
DialogPrimitiveBodytab index made in this merged PR: #3316🛠️ Detailed description
Related links:
DialogPrimitive- Change tabindex of Body to -1 (HDS-4905) #3316🔗 External links
👀 Component checklist
[ ] A changelog entry was added via [Changesets](- a changelog entry was deleted)(https://github.com/changesets/changesets) if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.