Skip to content

TESTING - hds-link-to-query - remove helper (HDS-5534) #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main-5.0.0
Choose a base branch
from
Draft

TESTING - hds-link-to-query - remove helper (HDS-5534) #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@
"./helpers/hds-format-date.js": "./dist/_app_/helpers/hds-format-date.js",
"./helpers/hds-format-relative.js": "./dist/_app_/helpers/hds-format-relative.js",
"./helpers/hds-link-to-models.js": "./dist/_app_/helpers/hds-link-to-models.js",
"./helpers/hds-link-to-query.js": "./dist/_app_/helpers/hds-link-to-query.js",
"./helpers/hds-t.js": "./dist/_app_/helpers/hds-t.js",
"./instance-initializers/load-sprite.js": "./dist/_app_/instance-initializers/load-sprite.js",
"./modifiers/hds-advanced-table-cell.js": "./dist/_app_/modifiers/hds-advanced-table-cell.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/app-footer/link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
@color="secondary"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/app-footer/status-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
style={{this.itemStyle}}
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/app-header/home-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class="hds-app-header__home-link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/app-side-nav/list/back-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class="hds-app-side-nav__list-item-link hds-app-side-nav__list-item-link--back-link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/app-side-nav/list/link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class="hds-app-side-nav__list-item-link {{if @isActive 'active'}}"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/hds/breadcrumb/item.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
class="hds-breadcrumb__link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
>
Expand All @@ -34,7 +34,7 @@
class="hds-breadcrumb__link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/button/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
class={{this.classNames}}
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/dropdown/list-item/checkmark.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Hds::Interactive
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/dropdown/list-item/interactive.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<Hds::Interactive
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/hds/interactive/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<this.linkToExternal
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
...attributes
Expand All @@ -15,7 +15,7 @@
<LinkTo
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
...attributes
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/link/inline.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class={{this.classNames}}
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/link/standalone.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
class={{this.classNames}}
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/pagination/nav/arrow.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<Hds::Interactive
class={{this.classNames}}
@route={{@route}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@models={{hds-link-to-models @model @models}}
@replace={{@replace}}
{{on "click" this.onClick}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/pagination/nav/number.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Hds::Interactive
class={{this.classNames}}
@route={{@route}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@models={{hds-link-to-models @model @models}}
@replace={{@replace}}
{{on "click" this.onClick}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/side-nav/header/home-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class="hds-side-nav__home-link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/side-nav/list/back-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class="hds-side-nav__list-item-link hds-side-nav__list-item-link--back-link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/hds/side-nav/list/link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class="hds-side-nav__list-item-link {{if @isActive 'active'}}"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/hds/tag/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
class="hds-tag__link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand All @@ -31,7 +31,7 @@
class="hds-tag__link"
@current-when={{@current-when}}
@models={{hds-link-to-models @model @models}}
@query={{hds-link-to-query @query}}
@query={{@query}}
@replace={{@replace}}
@route={{@route}}
@isRouteExternal={{@isRouteExternal}}
Expand Down
29 changes: 0 additions & 29 deletions packages/components/src/helpers/hds-link-to-query.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/components/src/template-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ import type HdsYieldComponent from './components/hds/yield';

// helpers
import type HdsLinkToModelsHelper from './helpers/hds-link-to-models.ts';
import type HdsLinkToQueryHelper from './helpers/hds-link-to-query.ts';
import type HdsFormatDateHelper from './helpers/hds-format-date.ts';
import type HdsFormatRelativeHelper from './helpers/hds-format-relative.ts';
import type HdsTHelper from './helpers/hds-t.ts';
Expand Down Expand Up @@ -999,9 +998,6 @@ export default interface HdsComponentsRegistry {
// hds-link-to-models
'hds-link-to-models': typeof HdsLinkToModelsHelper;

// hds-link-to-query
'hds-link-to-query': typeof HdsLinkToQueryHelper;

// hds-format-date
'hds-format-date': typeof HdsFormatDateHelper;

Expand Down
16 changes: 0 additions & 16 deletions showcase/tests/unit/helpers/hds-link-to-query-test.js
View file
Open in desktop

This file was deleted.

Loading